* [PATCH] staging: sm750fb: fix checkpatch warning architecture specific defines should be avoided
@ 2025-02-12 7:43 Michael Anckaert
2025-02-12 8:00 ` Thomas Zimmermann
0 siblings, 1 reply; 2+ messages in thread
From: Michael Anckaert @ 2025-02-12 7:43 UTC (permalink / raw)
To: Sudip Mukherjee, Teddy Wang, Greg Kroah-Hartman,
open list:STAGING - SILICON MOTION SM750 FRAME BUFFER DRIVER,
open list:STAGING SUBSYSTEM, open list
Replace architecture-specific defines with CONFIG_X86 checks to improve
portability and adhere to kernel coding standards.
Fixes checkpatch warning:
- CHECK: architecture specific defines should be avoided.
Changes made:
- Using CONFIG_X86 instead of i386 and x86.
Signed-off-by: Michael Anckaert <michael.anckaert@gmail.com>
---
drivers/staging/sm750fb/ddk750_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 02860d3ec365..67a2f60440ca 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -229,7 +229,7 @@ int ddk750_init_hw(struct initchip_param *p_init_param)
reg |= (VGA_CONFIGURATION_PLL | VGA_CONFIGURATION_MODE);
poke32(VGA_CONFIGURATION, reg);
} else {
-#if defined(__i386__) || defined(__x86_64__)
+#ifdef CONFIG_X86
/* set graphic mode via IO method */
outb_p(0x88, 0x3d4);
outb_p(0x06, 0x3d5);
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: sm750fb: fix checkpatch warning architecture specific defines should be avoided
2025-02-12 7:43 [PATCH] staging: sm750fb: fix checkpatch warning architecture specific defines should be avoided Michael Anckaert
@ 2025-02-12 8:00 ` Thomas Zimmermann
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Zimmermann @ 2025-02-12 8:00 UTC (permalink / raw)
To: Michael Anckaert, Sudip Mukherjee, Teddy Wang, Greg Kroah-Hartman,
open list:STAGING - SILICON MOTION SM750 FRAME BUFFER DRIVER,
open list:STAGING SUBSYSTEM, open list
Hi
Am 12.02.25 um 08:43 schrieb Michael Anckaert:
> Replace architecture-specific defines with CONFIG_X86 checks to improve
> portability and adhere to kernel coding standards.
>
> Fixes checkpatch warning:
> - CHECK: architecture specific defines should be avoided.
>
> Changes made:
> - Using CONFIG_X86 instead of i386 and x86.
>
> Signed-off-by: Michael Anckaert <michael.anckaert@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_chip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 02860d3ec365..67a2f60440ca 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -229,7 +229,7 @@ int ddk750_init_hw(struct initchip_param *p_init_param)
> reg |= (VGA_CONFIGURATION_PLL | VGA_CONFIGURATION_MODE);
> poke32(VGA_CONFIGURATION, reg);
> } else {
> -#if defined(__i386__) || defined(__x86_64__)
> +#ifdef CONFIG_X86
> /* set graphic mode via IO method */
> outb_p(0x88, 0x3d4);
> outb_p(0x06, 0x3d5);
Maybe move the '} else {' into the ifdef to avoid the possibly empty
else branch. I also wonder why this is only being done on x86. There are
other systems with VGA.
In any case
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Best regards
Thomas
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-12 8:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-12 7:43 [PATCH] staging: sm750fb: fix checkpatch warning architecture specific defines should be avoided Michael Anckaert
2025-02-12 8:00 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox