* [PATCH] fbcon: Make fbcon_registered_fb and fbcon_num_registered_fb static
@ 2023-08-03 2:09 GUO Zihua
2023-08-03 8:40 ` Daniel Vetter
0 siblings, 1 reply; 4+ messages in thread
From: GUO Zihua @ 2023-08-03 2:09 UTC (permalink / raw)
To: daniel, deller; +Cc: linux-fbdev, dri-devel
fbcon_registered_fb and fbcon_num_registered_fb is not referred outside
drivers/video/fbdev/core/fbcon.c, so make them static.
Signed-off-by: GUO Zihua <guozihua@huawei.com>
---
drivers/video/fbdev/core/fbcon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index 887fad44e7ec..976900d6893c 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -102,8 +102,8 @@ enum {
static struct fbcon_display fb_display[MAX_NR_CONSOLES];
-struct fb_info *fbcon_registered_fb[FB_MAX];
-int fbcon_num_registered_fb;
+static struct fb_info *fbcon_registered_fb[FB_MAX];
+static int fbcon_num_registered_fb;
#define fbcon_for_each_registered_fb(i) \
for (i = 0; WARN_CONSOLE_UNLOCKED(), i < FB_MAX; i++) \
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] fbcon: Make fbcon_registered_fb and fbcon_num_registered_fb static
2023-08-03 2:09 [PATCH] fbcon: Make fbcon_registered_fb and fbcon_num_registered_fb static GUO Zihua
@ 2023-08-03 8:40 ` Daniel Vetter
2023-08-03 8:52 ` Daniel Vetter
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Vetter @ 2023-08-03 8:40 UTC (permalink / raw)
To: GUO Zihua; +Cc: daniel, deller, linux-fbdev, dri-devel
On Thu, Aug 03, 2023 at 10:09:39AM +0800, GUO Zihua wrote:
> fbcon_registered_fb and fbcon_num_registered_fb is not referred outside
> drivers/video/fbdev/core/fbcon.c, so make them static.
>
> Signed-off-by: GUO Zihua <guozihua@huawei.com>
Applied both of your patches to drm-misc-next.
-Daniel
> ---
> drivers/video/fbdev/core/fbcon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> index 887fad44e7ec..976900d6893c 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -102,8 +102,8 @@ enum {
>
> static struct fbcon_display fb_display[MAX_NR_CONSOLES];
>
> -struct fb_info *fbcon_registered_fb[FB_MAX];
> -int fbcon_num_registered_fb;
> +static struct fb_info *fbcon_registered_fb[FB_MAX];
> +static int fbcon_num_registered_fb;
>
> #define fbcon_for_each_registered_fb(i) \
> for (i = 0; WARN_CONSOLE_UNLOCKED(), i < FB_MAX; i++) \
> --
> 2.17.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fbcon: Make fbcon_registered_fb and fbcon_num_registered_fb static
2023-08-03 8:40 ` Daniel Vetter
@ 2023-08-03 8:52 ` Daniel Vetter
2023-08-03 9:14 ` Guozihua (Scott)
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Vetter @ 2023-08-03 8:52 UTC (permalink / raw)
To: GUO Zihua; +Cc: daniel, deller, linux-fbdev, dri-devel
On Thu, Aug 03, 2023 at 10:40:35AM +0200, Daniel Vetter wrote:
> On Thu, Aug 03, 2023 at 10:09:39AM +0800, GUO Zihua wrote:
> > fbcon_registered_fb and fbcon_num_registered_fb is not referred outside
> > drivers/video/fbdev/core/fbcon.c, so make them static.
> >
> > Signed-off-by: GUO Zihua <guozihua@huawei.com>
>
> Applied both of your patches to drm-misc-next.
Correction, I dropped the agpgart patch again because amd gart x86 arch
code needs that symbol.
> -Daniel
>
> > ---
> > drivers/video/fbdev/core/fbcon.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> > index 887fad44e7ec..976900d6893c 100644
> > --- a/drivers/video/fbdev/core/fbcon.c
> > +++ b/drivers/video/fbdev/core/fbcon.c
> > @@ -102,8 +102,8 @@ enum {
> >
> > static struct fbcon_display fb_display[MAX_NR_CONSOLES];
> >
> > -struct fb_info *fbcon_registered_fb[FB_MAX];
> > -int fbcon_num_registered_fb;
> > +static struct fb_info *fbcon_registered_fb[FB_MAX];
> > +static int fbcon_num_registered_fb;
> >
> > #define fbcon_for_each_registered_fb(i) \
> > for (i = 0; WARN_CONSOLE_UNLOCKED(), i < FB_MAX; i++) \
> > --
> > 2.17.1
> >
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fbcon: Make fbcon_registered_fb and fbcon_num_registered_fb static
2023-08-03 8:52 ` Daniel Vetter
@ 2023-08-03 9:14 ` Guozihua (Scott)
0 siblings, 0 replies; 4+ messages in thread
From: Guozihua (Scott) @ 2023-08-03 9:14 UTC (permalink / raw)
To: Daniel Vetter; +Cc: deller, linux-fbdev, dri-devel
On 2023/8/3 16:52, Daniel Vetter wrote:
> On Thu, Aug 03, 2023 at 10:40:35AM +0200, Daniel Vetter wrote:
>> On Thu, Aug 03, 2023 at 10:09:39AM +0800, GUO Zihua wrote:
>>> fbcon_registered_fb and fbcon_num_registered_fb is not referred outside
>>> drivers/video/fbdev/core/fbcon.c, so make them static.
>>>
>>> Signed-off-by: GUO Zihua <guozihua@huawei.com>
>>
>> Applied both of your patches to drm-misc-next.
>
> Correction, I dropped the agpgart patch again because amd gart x86 arch
> code needs that symbol.
Thanks Daniel. Blind enough to not found this usage while making the
patch, sorry for the burden.
>
>> -Daniel
>>
>>> ---
>>> drivers/video/fbdev/core/fbcon.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
>>> index 887fad44e7ec..976900d6893c 100644
>>> --- a/drivers/video/fbdev/core/fbcon.c
>>> +++ b/drivers/video/fbdev/core/fbcon.c
>>> @@ -102,8 +102,8 @@ enum {
>>>
>>> static struct fbcon_display fb_display[MAX_NR_CONSOLES];
>>>
>>> -struct fb_info *fbcon_registered_fb[FB_MAX];
>>> -int fbcon_num_registered_fb;
>>> +static struct fb_info *fbcon_registered_fb[FB_MAX];
>>> +static int fbcon_num_registered_fb;
>>>
>>> #define fbcon_for_each_registered_fb(i) \
>>> for (i = 0; WARN_CONSOLE_UNLOCKED(), i < FB_MAX; i++) \
>>> --
>>> 2.17.1
>>>
>>
>> --
>> Daniel Vetter
>> Software Engineer, Intel Corporation
>> http://blog.ffwll.ch
>
--
Best
GUO Zihua
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-03 9:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-03 2:09 [PATCH] fbcon: Make fbcon_registered_fb and fbcon_num_registered_fb static GUO Zihua
2023-08-03 8:40 ` Daniel Vetter
2023-08-03 8:52 ` Daniel Vetter
2023-08-03 9:14 ` Guozihua (Scott)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox