* [PATCH] video: fbdev: pm2fb: unwind WC setup on probe failure
@ 2026-06-21 7:19 Haoxiang Li
2026-06-23 8:19 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Haoxiang Li @ 2026-06-21 7:19 UTC (permalink / raw)
To: deller; +Cc: linux-fbdev, linux-kernel, Haoxiang Li
Add arch_phys_wc_del() on error path to keep the
write-combining setup balanced when later probe
steps fail.
Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
---
drivers/video/fbdev/pm2fb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/pm2fb.c b/drivers/video/fbdev/pm2fb.c
index f34429829b7d..82408503c281 100644
--- a/drivers/video/fbdev/pm2fb.c
+++ b/drivers/video/fbdev/pm2fb.c
@@ -1711,6 +1711,7 @@ static int pm2fb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
err_exit_both:
kfree(info->pixmap.addr);
err_exit_pixmap:
+ arch_phys_wc_del(default_par->wc_cookie);
iounmap(info->screen_base);
release_mem_region(pm2fb_fix.smem_start, pm2fb_fix.smem_len);
err_exit_mmio:
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fbdev: pm2fb: unwind WC setup on probe failure
2026-06-21 7:19 [PATCH] video: fbdev: pm2fb: unwind WC setup on probe failure Haoxiang Li
@ 2026-06-23 8:19 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2026-06-23 8:19 UTC (permalink / raw)
To: Haoxiang Li; +Cc: linux-fbdev, linux-kernel
On 6/21/26 09:19, Haoxiang Li wrote:
> Add arch_phys_wc_del() on error path to keep the
> write-combining setup balanced when later probe
> steps fail.
>
> Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
> ---
> drivers/video/fbdev/pm2fb.c | 1 +
> 1 file changed, 1 insertion(+)
applied.
Thanks!
Helge
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-23 8:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-21 7:19 [PATCH] video: fbdev: pm2fb: unwind WC setup on probe failure Haoxiang Li
2026-06-23 8:19 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox