* [PATCH] staging: fbtft: remove trailing semicolons from macro definitions
@ 2026-10-18 15:35 Comfort Oyewole
2026-10-18 17:13 ` Julia Lawall
2026-10-19 7:15 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: Comfort Oyewole @ 2026-10-18 15:35 UTC (permalink / raw)
To: gregkh, andy; +Cc: outreachy, linux-staging, linux-fbdev
Remove trailing semicolons from macro definitions to allow the
macros to be used where callers provide their own trailing semicolon
Signed-off-by: Comfort Oyewole <coyewole7@gmail.com>
---
drivers/staging/fbtft/fbtft.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index 40a7567df1eb..1ab1658e8321 100644
--- a/drivers/staging/fbtft/fbtft.h
+++ b/drivers/staging/fbtft/fbtft.h
@@ -277,7 +277,7 @@ static const struct of_device_id dt_ids[] = { \
{ .compatible = _compatible }, \
{}, \
}; \
-MODULE_DEVICE_TABLE(of, dt_ids);
+MODULE_DEVICE_TABLE(of, dt_ids)
#define FBTFT_SPI_DRIVER(_name, _compatible, _display, _spi_ids) \
\
@@ -301,7 +301,7 @@ static struct spi_driver fbtft_driver_spi_driver = { \
.id_table = _spi_ids, \
.probe = fbtft_driver_probe_spi, \
.remove = fbtft_driver_remove_spi, \
-};
+}
#define FBTFT_REGISTER_DRIVER(_name, _compatible, _display) \
\
@@ -350,8 +350,8 @@ static void __exit fbtft_driver_module_exit(void) \
platform_driver_unregister(&fbtft_driver_platform_driver); \
} \
\
-module_init(fbtft_driver_module_init); \
-module_exit(fbtft_driver_module_exit);
+module_init(fbtft_driver_module_init) \
+module_exit(fbtft_driver_module_exit)
#define FBTFT_REGISTER_SPI_DRIVER(_name, _comp_vend, _comp_dev, _display) \
\
@@ -361,11 +361,11 @@ static const struct spi_device_id spi_ids[] = { \
{ .name = _comp_dev }, \
{}, \
}; \
-MODULE_DEVICE_TABLE(spi, spi_ids); \
+MODULE_DEVICE_TABLE(spi, spi_ids) \
\
FBTFT_SPI_DRIVER(_name, _comp_vend "," _comp_dev, _display, spi_ids) \
\
-module_spi_driver(fbtft_driver_spi_driver);
+module_spi_driver(fbtft_driver_spi_driver)
/* Debug macros */
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: fbtft: remove trailing semicolons from macro definitions
2026-10-18 15:35 [PATCH] staging: fbtft: remove trailing semicolons from macro definitions Comfort Oyewole
@ 2026-10-18 17:13 ` Julia Lawall
2026-10-19 7:15 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2026-10-18 17:13 UTC (permalink / raw)
To: Comfort Oyewole; +Cc: gregkh, andy, outreachy, linux-staging, linux-fbdev
> On 18 Oct 2026, at 11:38, Comfort Oyewole <coyewole7@gmail.com> wrote:
>
> Remove trailing semicolons from macro definitions to allow the
> macros to be used where callers provide their own trailing semicolon
It would be good for the log message to indicate that you have checked that the existing usage sites include their semicolons.
>
> Signed-off-by: Comfort Oyewole <coyewole7@gmail.com>
> ---
> drivers/staging/fbtft/fbtft.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
> index 40a7567df1eb..1ab1658e8321 100644
> --- a/drivers/staging/fbtft/fbtft.h
> +++ b/drivers/staging/fbtft/fbtft.h
> @@ -277,7 +277,7 @@ static const struct of_device_id dt_ids[] = { \
> { .compatible = _compatible }, \
> {}, \
> }; \
> -MODULE_DEVICE_TABLE(of, dt_ids);
> +MODULE_DEVICE_TABLE(of, dt_ids)
>
> #define FBTFT_SPI_DRIVER(_name, _compatible, _display, _spi_ids) \
> \
> @@ -301,7 +301,7 @@ static struct spi_driver fbtft_driver_spi_driver = { \
> .id_table = _spi_ids, \
> .probe = fbtft_driver_probe_spi, \
> .remove = fbtft_driver_remove_spi, \
> -};
> +}
>
> #define FBTFT_REGISTER_DRIVER(_name, _compatible, _display) \
> \
> @@ -350,8 +350,8 @@ static void __exit fbtft_driver_module_exit(void) \
> platform_driver_unregister(&fbtft_driver_platform_driver); \
> } \
> \
> -module_init(fbtft_driver_module_init); \
> -module_exit(fbtft_driver_module_exit);
> +module_init(fbtft_driver_module_init) \
> +module_exit(fbtft_driver_module_exit)
>
> #define FBTFT_REGISTER_SPI_DRIVER(_name, _comp_vend, _comp_dev, _display) \
> \
> @@ -361,11 +361,11 @@ static const struct spi_device_id spi_ids[] = { \
> { .name = _comp_dev }, \
> {}, \
> }; \
> -MODULE_DEVICE_TABLE(spi, spi_ids); \
> +MODULE_DEVICE_TABLE(spi, spi_ids) \
> \
> FBTFT_SPI_DRIVER(_name, _comp_vend "," _comp_dev, _display, spi_ids) \
> \
> -module_spi_driver(fbtft_driver_spi_driver);
> +module_spi_driver(fbtft_driver_spi_driver)
>
> /* Debug macros */
>
> --
> 2.53.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: fbtft: remove trailing semicolons from macro definitions
2026-10-18 15:35 [PATCH] staging: fbtft: remove trailing semicolons from macro definitions Comfort Oyewole
2026-10-18 17:13 ` Julia Lawall
@ 2026-10-19 7:15 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2026-10-19 7:15 UTC (permalink / raw)
To: Comfort Oyewole; +Cc: gregkh, andy, outreachy, linux-staging, linux-fbdev
On Sun, Oct 18, 2026 at 04:35:34PM +0100, Comfort Oyewole wrote:
> Remove trailing semicolons from macro definitions to allow the
> macros to be used where callers provide their own trailing semicolon
>
This doesn't match what the patch does. I'm surprised that this code
compiles with all the semi-colons removed, honestly. :P
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-19 7:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-18 15:35 [PATCH] staging: fbtft: remove trailing semicolons from macro definitions Comfort Oyewole
2026-10-18 17:13 ` Julia Lawall
2026-10-19 7:15 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox