* [PATCH -next] fbdev: omap2: omapfb: trivial code cleanup @ 2019-03-01 1:53 ` Yue Haibing 2019-03-01 14:50 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 3+ messages in thread From: Yue Haibing @ 2019-03-01 1:53 UTC (permalink / raw) To: b.zolnierkie, trivial, gregkh Cc: linux-kernel, linux-fbdev, dri-devel, linux-omap, YueHaibing From: YueHaibing <yuehaibing@huawei.com> After commit 60d2fa0dad06 ("fbdev: omap2: no need to check return value of debugfs_create functions"), there are corner code need to be cleaned. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/video/fbdev/omap2/omapfb/dss/core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c index 7e6a3eb..b5956a1 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c @@ -136,7 +136,6 @@ static inline void dss_uninitialize_debugfs(void) } void dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) { - return 0; } #endif /* CONFIG_FB_OMAP2_DSS_DEBUGFS */ @@ -169,8 +168,6 @@ static struct notifier_block omap_dss_pm_notif_block = { static int __init omap_dss_probe(struct platform_device *pdev) { - int r; - core.pdev = pdev; dss_features_init(omapdss_get_version()); -- 2.7.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] fbdev: omap2: omapfb: trivial code cleanup 2019-03-01 1:53 ` [PATCH -next] fbdev: omap2: omapfb: trivial code cleanup Yue Haibing @ 2019-03-01 14:50 ` Bartlomiej Zolnierkiewicz 2019-03-02 1:20 ` YueHaibing 0 siblings, 1 reply; 3+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2019-03-01 14:50 UTC (permalink / raw) To: Yue Haibing Cc: trivial, gregkh, linux-kernel, linux-fbdev, dri-devel, linux-omap Hi, On 03/01/2019 02:53 AM, Yue Haibing wrote: > From: YueHaibing <yuehaibing@huawei.com> > > After commit 60d2fa0dad06 ("fbdev: omap2: no need to check > return value of debugfs_create functions"), there are corner > code need to be cleaned. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Thanks but I've already applied earlier patch from Anders Roxell: https://marc.info/?l=linux-fbdev&m\x155004766902831&w=2 > --- > drivers/video/fbdev/omap2/omapfb/dss/core.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c > index 7e6a3eb..b5956a1 100644 > --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c > +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c > @@ -136,7 +136,6 @@ static inline void dss_uninitialize_debugfs(void) > } > void dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) > { > - return 0; > } > #endif /* CONFIG_FB_OMAP2_DSS_DEBUGFS */ > > @@ -169,8 +168,6 @@ static struct notifier_block omap_dss_pm_notif_block = { > > static int __init omap_dss_probe(struct platform_device *pdev) > { > - int r; > - > core.pdev = pdev; > > dss_features_init(omapdss_get_version()); Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] fbdev: omap2: omapfb: trivial code cleanup 2019-03-01 14:50 ` Bartlomiej Zolnierkiewicz @ 2019-03-02 1:20 ` YueHaibing 0 siblings, 0 replies; 3+ messages in thread From: YueHaibing @ 2019-03-02 1:20 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz Cc: trivial, gregkh, linux-kernel, linux-fbdev, dri-devel, linux-omap On 2019/3/1 22:50, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On 03/01/2019 02:53 AM, Yue Haibing wrote: >> From: YueHaibing <yuehaibing@huawei.com> >> >> After commit 60d2fa0dad06 ("fbdev: omap2: no need to check >> return value of debugfs_create functions"), there are corner >> code need to be cleaned. >> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Thanks but I've already applied earlier patch from Anders Roxell: > > https://marc.info/?l=linux-fbdev&m\x155004766902831&w=2 Good to know this, Thanks! > >> --- >> drivers/video/fbdev/omap2/omapfb/dss/core.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c >> index 7e6a3eb..b5956a1 100644 >> --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c >> +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c >> @@ -136,7 +136,6 @@ static inline void dss_uninitialize_debugfs(void) >> } >> void dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) >> { >> - return 0; >> } >> #endif /* CONFIG_FB_OMAP2_DSS_DEBUGFS */ >> >> @@ -169,8 +168,6 @@ static struct notifier_block omap_dss_pm_notif_block = { >> >> static int __init omap_dss_probe(struct platform_device *pdev) >> { >> - int r; >> - >> core.pdev = pdev; >> >> dss_features_init(omapdss_get_version()); > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-02 1:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20190301015537epcas4p242dee277b9b0b4953775bb948985775c@epcas4p2.samsung.com>
2019-03-01 1:53 ` [PATCH -next] fbdev: omap2: omapfb: trivial code cleanup Yue Haibing
2019-03-01 14:50 ` Bartlomiej Zolnierkiewicz
2019-03-02 1:20 ` YueHaibing
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox