Linux Framebuffer Layer development
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Helge Deller <deller@gmx.de>, Zhou Zhu <zzhu3@marvell.com>,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video: fbdev: mmp: Fix typo in code comment
Date: Fri, 24 Nov 2023 07:34:28 -0800	[thread overview]
Message-ID: <de706c0c-d6dc-45d4-a316-56ff56be5c25@infradead.org> (raw)
In-Reply-To: <20231124095221.659445-1-dario.binacchi@amarulasolutions.com>

Hi,

On 11/24/23 01:52, Dario Binacchi wrote:
> s/singals/signals/
> 
> Fixes: 641b4b1b6a7c ("video: mmpdisp: add spi port in display controller")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
> 
>  drivers/video/fbdev/mmp/hw/mmp_spi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/mmp/hw/mmp_spi.c b/drivers/video/fbdev/mmp/hw/mmp_spi.c
> index 16401eb95c6c..64e34b7e739e 100644
> --- a/drivers/video/fbdev/mmp/hw/mmp_spi.c
> +++ b/drivers/video/fbdev/mmp/hw/mmp_spi.c
> @@ -91,7 +91,7 @@ static int lcd_spi_setup(struct spi_device *spi)
>  	writel(tmp, reg_base + LCD_SPU_SPI_CTRL);
>  
>  	/*
> -	 * After set mode it need a time to pull up the spi singals,
> +	 * After set mode it need a time to pull up the spi signals,

Also:
	                  it needs time
or
	                  it needs some time

>  	 * or it would cause the wrong waveform when send spi command,
>  	 * especially on pxa910h
>  	 */

thanks.
-- 
~Randy

  reply	other threads:[~2023-11-24 15:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-24  9:52 [PATCH] video: fbdev: mmp: Fix typo in code comment Dario Binacchi
2023-11-24 15:34 ` Randy Dunlap [this message]
2023-11-25  8:56   ` Helge Deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de706c0c-d6dc-45d4-a316-56ff56be5c25@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zzhu3@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox