* [PATCH] video: fbdev: mmp: Fix typo in code comment
@ 2023-11-24 9:52 Dario Binacchi
2023-11-24 15:34 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Dario Binacchi @ 2023-11-24 9:52 UTC (permalink / raw)
To: linux-kernel
Cc: Dario Binacchi, Andrew Morton, Haojian Zhuang, Helge Deller,
Zhou Zhu, dri-devel, linux-fbdev
s/singals/signals/
Fixes: 641b4b1b6a7c ("video: mmpdisp: add spi port in display controller")
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
drivers/video/fbdev/mmp/hw/mmp_spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/mmp/hw/mmp_spi.c b/drivers/video/fbdev/mmp/hw/mmp_spi.c
index 16401eb95c6c..64e34b7e739e 100644
--- a/drivers/video/fbdev/mmp/hw/mmp_spi.c
+++ b/drivers/video/fbdev/mmp/hw/mmp_spi.c
@@ -91,7 +91,7 @@ static int lcd_spi_setup(struct spi_device *spi)
writel(tmp, reg_base + LCD_SPU_SPI_CTRL);
/*
- * After set mode it need a time to pull up the spi singals,
+ * After set mode it need a time to pull up the spi signals,
* or it would cause the wrong waveform when send spi command,
* especially on pxa910h
*/
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] video: fbdev: mmp: Fix typo in code comment
2023-11-24 9:52 [PATCH] video: fbdev: mmp: Fix typo in code comment Dario Binacchi
@ 2023-11-24 15:34 ` Randy Dunlap
2023-11-25 8:56 ` Helge Deller
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2023-11-24 15:34 UTC (permalink / raw)
To: Dario Binacchi, linux-kernel
Cc: Andrew Morton, Haojian Zhuang, Helge Deller, Zhou Zhu, dri-devel,
linux-fbdev
Hi,
On 11/24/23 01:52, Dario Binacchi wrote:
> s/singals/signals/
>
> Fixes: 641b4b1b6a7c ("video: mmpdisp: add spi port in display controller")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>
> drivers/video/fbdev/mmp/hw/mmp_spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/mmp/hw/mmp_spi.c b/drivers/video/fbdev/mmp/hw/mmp_spi.c
> index 16401eb95c6c..64e34b7e739e 100644
> --- a/drivers/video/fbdev/mmp/hw/mmp_spi.c
> +++ b/drivers/video/fbdev/mmp/hw/mmp_spi.c
> @@ -91,7 +91,7 @@ static int lcd_spi_setup(struct spi_device *spi)
> writel(tmp, reg_base + LCD_SPU_SPI_CTRL);
>
> /*
> - * After set mode it need a time to pull up the spi singals,
> + * After set mode it need a time to pull up the spi signals,
Also:
it needs time
or
it needs some time
> * or it would cause the wrong waveform when send spi command,
> * especially on pxa910h
> */
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] video: fbdev: mmp: Fix typo in code comment
2023-11-24 15:34 ` Randy Dunlap
@ 2023-11-25 8:56 ` Helge Deller
0 siblings, 0 replies; 3+ messages in thread
From: Helge Deller @ 2023-11-25 8:56 UTC (permalink / raw)
To: Randy Dunlap, Dario Binacchi, linux-kernel
Cc: Andrew Morton, Haojian Zhuang, Zhou Zhu, dri-devel, linux-fbdev
On 11/24/23 16:34, Randy Dunlap wrote:
> Hi,
>
> On 11/24/23 01:52, Dario Binacchi wrote:
>> s/singals/signals/
>>
>> Fixes: 641b4b1b6a7c ("video: mmpdisp: add spi port in display controller")
>> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>> ---
>>
>> drivers/video/fbdev/mmp/hw/mmp_spi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/fbdev/mmp/hw/mmp_spi.c b/drivers/video/fbdev/mmp/hw/mmp_spi.c
>> index 16401eb95c6c..64e34b7e739e 100644
>> --- a/drivers/video/fbdev/mmp/hw/mmp_spi.c
>> +++ b/drivers/video/fbdev/mmp/hw/mmp_spi.c
>> @@ -91,7 +91,7 @@ static int lcd_spi_setup(struct spi_device *spi)
>> writel(tmp, reg_base + LCD_SPU_SPI_CTRL);
>>
>> /*
>> - * After set mode it need a time to pull up the spi singals,
>> + * After set mode it need a time to pull up the spi signals,
>
> Also:
> it needs time
> or
> it needs some time
I've fixed it up and applied that patch to fbdev git tree.
Thanks!
Helge
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-25 8:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-24 9:52 [PATCH] video: fbdev: mmp: Fix typo in code comment Dario Binacchi
2023-11-24 15:34 ` Randy Dunlap
2023-11-25 8:56 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox