* [PATCH] fbdev: i740fb: use memset_io() to clear screen
@ 2022-04-10 20:28 Ondrej Zary
2022-04-11 6:16 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Ondrej Zary @ 2022-04-10 20:28 UTC (permalink / raw)
To: Helge Deller; +Cc: linux-fbdev, dri-devel, linux-kernel
sparse complains that using memset() on __iomem pointer is wrong:
incorrect type in argument 1 (different address spaces)
Use memset_io() to clear screen instead.
Tested on real i740 cards.
Signed-off-by: Ondrej Zary <linux@zary.sk>
---
drivers/video/fbdev/i740fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/i740fb.c b/drivers/video/fbdev/i740fb.c
index 52cce0db8bd3..dd45ea8203be 100644
--- a/drivers/video/fbdev/i740fb.c
+++ b/drivers/video/fbdev/i740fb.c
@@ -740,7 +740,7 @@ static int i740fb_set_par(struct fb_info *info)
if (i)
return i;
- memset(info->screen_base, 0, info->screen_size);
+ memset_io(info->screen_base, 0, info->screen_size);
vga_protect(par);
--
Ondrej Zary
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fbdev: i740fb: use memset_io() to clear screen
2022-04-10 20:28 [PATCH] fbdev: i740fb: use memset_io() to clear screen Ondrej Zary
@ 2022-04-11 6:16 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2022-04-11 6:16 UTC (permalink / raw)
To: Ondrej Zary; +Cc: linux-fbdev, dri-devel, linux-kernel
On 4/10/22 22:28, Ondrej Zary wrote:
> sparse complains that using memset() on __iomem pointer is wrong:
> incorrect type in argument 1 (different address spaces)
>
> Use memset_io() to clear screen instead.
>
> Tested on real i740 cards.
>
> Signed-off-by: Ondrej Zary <linux@zary.sk>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/i740fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/i740fb.c b/drivers/video/fbdev/i740fb.c
> index 52cce0db8bd3..dd45ea8203be 100644
> --- a/drivers/video/fbdev/i740fb.c
> +++ b/drivers/video/fbdev/i740fb.c
> @@ -740,7 +740,7 @@ static int i740fb_set_par(struct fb_info *info)
> if (i)
> return i;
>
> - memset(info->screen_base, 0, info->screen_size);
> + memset_io(info->screen_base, 0, info->screen_size);
>
> vga_protect(par);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-11 6:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-10 20:28 [PATCH] fbdev: i740fb: use memset_io() to clear screen Ondrej Zary
2022-04-11 6:16 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox