From: Helge Deller <deller@gmx.de>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>,
Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] fbdev: maxine: use MODULE_LICENSE() unconditionally
Date: Tue, 18 Aug 2026 11:11:22 +0200 [thread overview]
Message-ID: <fb011f12-ae50-4f41-a03f-ba587aba4bb2@gmx.de> (raw)
In-Reply-To: <alpine.DEB.2.21.2608171800240.14132@angie.orcam.me.uk>
On 8/17/26 19:09, Maciej W. Rozycki wrote:
> On Fri, 14 Aug 2026, Randy Dunlap wrote:
>
>> This driver cannot be built as a loadable module so testing for
>> "#ifdef MODULE" is not appropriate here.
>> Also, MODULE_LICENSE() is always available.
>
> It might best be reordered to the end of file, cf. pmagb-b-fb.c, though
> I'm not sure if we want to be pedantic enough to do it with a separate
> change.
No need to send a seperate patch.
I've fixed it up accordingly and pushed the updated patch to the fbdev for-next
git tree while I added your Acked-by tags.
Helge
> Anyway:
>
> Acked-by: Maciej W. Rozycki <macro@orcam.me.uk>
> NB making the driver modular ought to be trivial once this has become a
> platform device; I have converted all the TURBOchannel drivers already.
> I have hesitated poking at this one without a live specimen though.
>
> Maciej
prev parent reply other threads:[~2026-08-18 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 18:42 [PATCH] fbdev: maxine: use MODULE_LICENSE() unconditionally Randy Dunlap
2026-08-14 19:40 ` Helge Deller
2026-08-17 17:09 ` Maciej W. Rozycki
2026-08-18 9:11 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb011f12-ae50-4f41-a03f-ba587aba4bb2@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).