* [PATCH 1/1] backlight: lm3630a_bl: Fix incorrect variable type
From: Sachin Kamat @ 2013-09-26 11:59 UTC (permalink / raw)
To: linux-fbdev
'lm3630a_read' returns a negative error code upon failure. This
will never get detected by unsigned 'rval'. Make it signed.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Daniel Jeong <gshark.jeong@gmail.com>
---
drivers/video/backlight/lm3630a_bl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index c63f918..65392f9 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip)
/* interrupt handling */
static void lm3630a_delayed_func(struct work_struct *work)
{
- unsigned int rval;
+ int rval;
struct lm3630a_chip *pchip;
pchip = container_of(work, struct lm3630a_chip, work.work);
--
1.7.9.5
^ permalink raw reply related
* Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels
From: Thierry Reding @ 2013-09-26 11:51 UTC (permalink / raw)
To: Tomi Valkeinen, Jingoo Han
Cc: Mike Dunn, Richard Purdie, Jean-Christophe Plagniol-Villard,
Grant Likely, Rob Herring, linux-pwm-u79uwXL29TY76Z2rM5mHXA,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Robert Jarzmik, Marek Vasut
In-Reply-To: <5244065A.8010408-l0cyMroinI0@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]
On Thu, Sep 26, 2013 at 01:03:06PM +0300, Tomi Valkeinen wrote:
[...]
> But if you and Thierry think this version is good, I'll take it.
That sounds like you want to take it through the fbdev tree. Jingoo is
listed (along with Richard, but he hasn't been responsive to email for
years) as maintainer for the backlight subsystem. Furthermore back at
the time when I began working on the PWM subsystem, the backlight sub-
system was pretty much orphaned, and pwm-backlight was by far the
biggest user of the PWM subsystem. I adopted the driver at the time
because it needed to be updated for PWM subsystem changes.
What's the plan going forward? Given the coupling between the PWM
subsystem and the pwm-backlight driver it might be useful to keep
maintaining it as part of the PWM subsystem. On the other hand, there's
some coupling between the driver and the backlight subsystem too.
I have a couple of patches queued up for 3.13 that rework parts of the
driver, so it'd be good to know how you guys want to handle this.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply
* Re: [PATCH 01/15] video: atmel_lcdfb: Remove redundant dev_set_drvdata
From: Sachin Kamat @ 2013-09-26 11:48 UTC (permalink / raw)
To: linux-fbdev
In-Reply-To: <1379658744-17113-2-git-send-email-sachin.kamat@linaro.org>
On 26 September 2013 16:05, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> On 20/09/13 09:32, Sachin Kamat wrote:
> I had to modify this one as follows. Are you fine with it?
Looks good to me. Thanks Tomi.
--
With warm regards,
Sachin
^ permalink raw reply
* [PATCH] video: mxsfb: Add missing break
From: Marek Vasut @ 2013-09-26 11:13 UTC (permalink / raw)
To: linux-arm-kernel
Add missing break into the restore function.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
drivers/video/mxsfb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index d250ed0..27197a8 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c
@@ -620,6 +620,7 @@ static int mxsfb_restore_mode(struct mxsfb_info *host)
break;
case 3:
bits_per_pixel = 32;
+ break;
case 1:
default:
return -EINVAL;
--
1.8.4.rc3
^ permalink raw reply related
* Re: [PATCH 39/51] DMA-API: others: use dma_set_coherent_mask()
From: Archit Taneja @ 2013-09-26 10:57 UTC (permalink / raw)
To: Russell King, alsa-devel, b43-dev, devel, devicetree, dri-devel,
e1000-devel, linux-arm-kernel, linux-crypto, linux-doc,
linux-fbdev, linux-ide, linux-media, linux-mmc, linux-nvme,
linux-omap, linuxppc-dev, linux-samsung-soc, linux-scsi,
linux-tegra, linux-usb, linux-wireless, netdev,
Solarflare linux maintainers, uclinux-dist-devel
Cc: Kukjin Kim, Joonyoung Shim, David Airlie, Seung-Woo Kim,
Rob Clark, Inki Dae, Kyungmin Park, Valkeinen, Tomi, Tejun Heo
In-Reply-To: <E1VMnNq-0007s4-HN@rmk-PC.arm.linux.org.uk>
Hi,
On Friday 20 September 2013 04:41 AM, Russell King wrote:
> The correct way for a driver to specify the coherent DMA mask is
> not to directly access the field in the struct device, but to use
> dma_set_coherent_mask(). Only arch and bus code should access this
> member directly.
>
> Convert all direct write accesses to using the correct API.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> drivers/ata/pata_ixp4xx_cf.c | 5 ++++-
> drivers/gpu/drm/exynos/exynos_drm_drv.c | 6 +++++-
> drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 5 +++--
> 3 files changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c
> index 1ec53f8..ddf470c 100644
> --- a/drivers/ata/pata_ixp4xx_cf.c
> +++ b/drivers/ata/pata_ixp4xx_cf.c
> @@ -144,6 +144,7 @@ static int ixp4xx_pata_probe(struct platform_device *pdev)
> struct ata_host *host;
> struct ata_port *ap;
> struct ixp4xx_pata_data *data = dev_get_platdata(&pdev->dev);
> + int ret;
>
> cs0 = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> cs1 = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> @@ -157,7 +158,9 @@ static int ixp4xx_pata_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> /* acquire resources and fill host */
> - pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
> + ret = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
> + if (ret)
> + return ret;
>
> data->cs0 = devm_ioremap(&pdev->dev, cs0->start, 0x1000);
> data->cs1 = devm_ioremap(&pdev->dev, cs1->start, 0x1000);
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> index bb82ef7..81192d0 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> @@ -286,7 +286,11 @@ static struct drm_driver exynos_drm_driver = {
>
> static int exynos_drm_platform_probe(struct platform_device *pdev)
> {
> - pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
> + int ret;
> +
> + ret = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
> + if (ret)
> + return ret;
>
> return drm_platform_init(&exynos_drm_driver, pdev);
> }
> diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> index acf6678..701c4c1 100644
> --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> @@ -664,8 +664,9 @@ static int omap_dmm_probe(struct platform_device *dev)
> }
>
> /* set dma mask for device */
> - /* NOTE: this is a workaround for the hwmod not initializing properly */
> - dev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
> + ret = dma_set_coherent_mask(&dev->dev, DMA_BIT_MASK(32));
> + if (ret)
> + goto fail;
Tested with omapdrm on omap4 panda es board.
Thanks,
Archit
^ permalink raw reply
* Re: [PATCH 01/15] video: atmel_lcdfb: Remove redundant dev_set_drvdata
From: Tomi Valkeinen @ 2013-09-26 10:35 UTC (permalink / raw)
To: linux-fbdev
In-Reply-To: <1379658744-17113-2-git-send-email-sachin.kamat@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 2407 bytes --]
On 20/09/13 09:32, Sachin Kamat wrote:
> Driver core sets driver data to NULL upon failure or remove.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> drivers/video/atmel_lcdfb.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
> index 34e934d..70052e7 100644
> --- a/drivers/video/atmel_lcdfb.c
> +++ b/drivers/video/atmel_lcdfb.c
> @@ -1318,7 +1318,6 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
> return 0;
>
> reset_drvdata:
> - dev_set_drvdata(dev, NULL);
> fb_dealloc_cmap(&info->cmap);
> unregister_irqs:
> cancel_work_sync(&sinfo->task);
> @@ -1379,7 +1378,6 @@ static int __exit atmel_lcdfb_remove(struct platform_device *pdev)
> atmel_lcdfb_free_video_memory(sinfo);
> }
>
> - dev_set_drvdata(dev, NULL);
> framebuffer_release(info);
>
> return 0;
>
I had to modify this one as follows. Are you fine with it?
commit 8d84d1223dbbaceb5cbf25b597e48a59c36b8c91
Author: Sachin Kamat <sachin.kamat@linaro.org>
Date: Fri Sep 20 12:02:10 2013 +0530
video: atmel_lcdfb: Remove redundant dev_set_drvdata
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
index df05550..3f7d6dc 100644
--- a/drivers/video/atmel_lcdfb.c
+++ b/drivers/video/atmel_lcdfb.c
@@ -1089,7 +1089,7 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
ret = register_framebuffer(info);
if (ret < 0) {
dev_err(dev, "failed to register framebuffer device: %d\n", ret);
- goto reset_drvdata;
+ goto free_cmap;
}
/* add selected videomode to modelist */
@@ -1105,8 +1105,6 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
return 0;
-reset_drvdata:
- dev_set_drvdata(dev, NULL);
free_cmap:
fb_dealloc_cmap(&info->cmap);
unregister_irqs:
@@ -1167,7 +1165,6 @@ static int __exit atmel_lcdfb_remove(struct platform_device *pdev)
atmel_lcdfb_free_video_memory(sinfo);
}
- dev_set_drvdata(dev, NULL);
framebuffer_release(info);
return 0;
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply related
* Re: [PATCH 1/2] video: jz4740-fb: Fix LCD_CMD bit definitions
From: Tomi Valkeinen @ 2013-09-26 10:24 UTC (permalink / raw)
To: linux-fbdev
In-Reply-To: <1379844109-10513-1-git-send-email-lars@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 953 bytes --]
On 22/09/13 13:01, Lars-Peter Clausen wrote:
> Fix the bit offsets for the LCD_CMD definitions.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> drivers/video/jz4740_fb.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/jz4740_fb.c b/drivers/video/jz4740_fb.c
> index 2c49112..23aa475 100644
> --- a/drivers/video/jz4740_fb.c
> +++ b/drivers/video/jz4740_fb.c
> @@ -99,9 +99,9 @@
> #define JZ_LCD_CTRL_BPP_15_16 0x4
> #define JZ_LCD_CTRL_BPP_18_24 0x5
>
> -#define JZ_LCD_CMD_SOF_IRQ BIT(15)
> -#define JZ_LCD_CMD_EOF_IRQ BIT(16)
> -#define JZ_LCD_CMD_ENABLE_PAL BIT(12)
> +#define JZ_LCD_CMD_SOF_IRQ BIT(31)
> +#define JZ_LCD_CMD_EOF_IRQ BIT(30)
> +#define JZ_LCD_CMD_ENABLE_PAL BIT(28)
>
> #define JZ_LCD_SYNC_MASK 0x3ff
>
>
Thanks, queuing this and the second patch for 3.13.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH] OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier
From: Tomi Valkeinen @ 2013-09-26 10:21 UTC (permalink / raw)
To: Mark Brown
Cc: Jean-Christophe Plagniol-Villard, linux-fbdev, linux-omap,
linaro-kernel
In-Reply-To: <20130926101247.GB19304@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On 26/09/13 13:12, Mark Brown wrote:
> On Thu, Sep 26, 2013 at 11:36:26AM +0300, Tomi Valkeinen wrote:
>
>> I wish we could "select" instead of "depends on"...
>
> We probably could.
I'm not so sure.
If we select BACKLIGHT_CLASS_DEVICE, we could end up compiling
backlight.c without fbdev, and backlight.c uses fb's funcs.
The funny thing is, there is FB_BACKLIGHT, which seems to be designed to
be selectable (and is selected). That one depends on FB, but if I'm not
mistaken, that dependency does not do anything if FB_BACKLIGHT is selected.
FB_BACKLIGHT in turn selects both BACKLIGHT_LCD_SUPPORT and
BACKLIGHT_CLASS_DEVICE, neither of which seem to be designed to be
selectable.
I think that's a bit broken. Anyway, I guess it's better to "depend on"
here, to be on the safe side.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH] pwm-backlight: add support for device tree gpio control
From: Tomi Valkeinen @ 2013-09-26 10:13 UTC (permalink / raw)
To: Mike Dunn, Thierry Reding
Cc: Richard Purdie, Jingoo Han, Jean-Christophe Plagniol-Villard,
Grant Likely, Rob Herring, linux-pwm-u79uwXL29TY76Z2rM5mHXA,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Robert Jarzmik, Marek Vasut
In-Reply-To: <523056A6.5060000-kFrNdAxtuftBDgjK7y7TUQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1854 bytes --]
On 11/09/13 14:40, Mike Dunn wrote:
> On 09/10/2013 10:21 AM, Thierry Reding wrote:
>> Do you have a real setup that actually needs multiple GPIOs? Usually
>> such a setup requires some kind of timing or other additional constraint
>> which can't be represented by this simple binding.
>>
>> Looking at the Palm Treo code it seems like the reason why multiple
>> GPIOs are needed is because one is to enable the backlight, while the
>> other is in fact used to enable the LCD panel.
>
>
> There are actually four GPIOs involved! (There is an embarrasingly horrible
> hack in arch/arm/mach-pxa/palmtreo.c that handles the others.) One is almost
> certainly simply backlight power. The other three are probably LCD related.
When you say "power", do you mean the gpio enables a regulator to feed
power to the backlight? If so, wouldn't that be a regulator, not gpio,
from the bl driver's point of view?
Generally speaking, this same problem appears in many places, but for
some reason especially in display. I'm a bit hesitant in adding "free
form" gpio/regulator support for drivers, as, as Thierry pointed out,
there are often timing requirements, or sometimes the gpios are
inverted, or sometimes the gpio is, in fact, a reset gpio, where you'll
assert the gpio for a short moment only.
I haven't seen new versions for the power sequences framework (without
DT support), I think it could help us here a bit by simplifying how we
present the sequences inside the driver. But we still need multiple
drivers or the same driver supporting multiple devices.
And I also think that the model where we have just one driver for, say,
backlight may not be enough. There may be multiple hardware components,
that used together will generate the backlight. And each component
requires specific management.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH] OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier
From: Mark Brown @ 2013-09-26 10:12 UTC (permalink / raw)
To: Tomi Valkeinen
Cc: Jean-Christophe Plagniol-Villard, linux-fbdev, linux-omap,
linaro-kernel
In-Reply-To: <5243F20A.9000707@ti.com>
[-- Attachment #1: Type: text/plain, Size: 139 bytes --]
On Thu, Sep 26, 2013 at 11:36:26AM +0300, Tomi Valkeinen wrote:
> I wish we could "select" instead of "depends on"...
We probably could.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply
* Re: [PATCH 1/2] framebuffer: arkfb: Fix framebugger typo
From: Joe Perches @ 2013-09-26 10:10 UTC (permalink / raw)
To: Tomi Valkeinen
Cc: Jean-Christophe Plagniol-Villard, linux-fbdev, linux-kernel
In-Reply-To: <524402A6.1040709@ti.com>
On Thu, 2013-09-26 at 12:47 +0300, Tomi Valkeinen wrote:
> On 20/09/13 04:53, Joe Perches wrote:
> > s/framebugger/framebuffer/
[]
> Thanks, queued for 3.13. Although I have to say I kinda like the sound
> of framebugger.
I wondered if I should even change it
because it _is_ kind of funny.
Maybe you should just leave it in.
^ permalink raw reply
* Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels
From: Tomi Valkeinen @ 2013-09-26 10:03 UTC (permalink / raw)
To: Mike Dunn, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w
Cc: Richard Purdie, Jingoo Han, Jean-Christophe Plagniol-Villard,
Grant Likely, Rob Herring, linux-pwm-u79uwXL29TY76Z2rM5mHXA,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Robert Jarzmik, Marek Vasut
In-Reply-To: <1379869196-19377-1-git-send-email-mikedunn-kFrNdAxtuftBDgjK7y7TUQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]
On 22/09/13 19:59, Mike Dunn wrote:
> Currently the driver assumes that the values specified in the
> brightness-levels device tree property increase as they are parsed from
> left to right. But boards that invert the signal between the PWM output
> and the backlight will need to specify decreasing brightness-levels.
> This patch removes the assumption that the last element of the array is
> the maximum value, and instead searches the array for the maximum value
> and uses that in the duty cycle calculation.
>
> Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
> ---
> Changelog:
> v2:
> - commit message reworded; correct line wrap used
> - 'max_level' variable renamed to 'scale'
> - loop counter variable type changed to unsigned int
> - value held in scale changed from array index to actual maximum level
> - blank lines added around loop for readability
As you said in a previous mail, the code is rather confusing. And, at
least to me, "scale" sounds an odd name there, especially as it's then
assigned to "max" local var. But if you and Thierry think this version
is good, I'll take it.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [patch 1/2] backlight: lm3630: signedness bug in lm3630a_chip_init()
From: Dan Carpenter @ 2013-09-26 9:53 UTC (permalink / raw)
To: linux-fbdev
In-Reply-To: <20130925085451.GA6661@elgon.mountain>
On Thu, Sep 26, 2013 at 12:43:43PM +0300, Tomi Valkeinen wrote:
> On 25/09/13 11:54, Dan Carpenter wrote:
> > "rval" needs to be signed for the error handling to work.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
> > index c63f918..65392f9 100644
> > --- a/drivers/video/backlight/lm3630a_bl.c
> > +++ b/drivers/video/backlight/lm3630a_bl.c
> > @@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip)
> > /* interrupt handling */
> > static void lm3630a_delayed_func(struct work_struct *work)
> > {
> > - unsigned int rval;
> > + int rval;
> > struct lm3630a_chip *pchip;
> >
> > pchip = container_of(work, struct lm3630a_chip, work.work);
> >
>
> There's no drivers/video/backlight/lm3630a_bl.c in v3.12. Which kernel
> is this for?
>
The story is that this driver wasn't submitted to you or to linux-fbdev
but only to lkml.
Andrew Morton (the only person who reads LKML) picked it up in his tree.
Probably at some point he will prod you into taking it through your
tree. Anyway, I resent the patches so they're in -mm now.
regards,
dan carpenter
^ permalink raw reply
* Re: [PATCH 1/2] framebuffer: arkfb: Fix framebugger typo
From: Tomi Valkeinen @ 2013-09-26 9:47 UTC (permalink / raw)
To: Joe Perches; +Cc: Jean-Christophe Plagniol-Villard, linux-fbdev, linux-kernel
In-Reply-To: <c94f3e342947923f20d4c12932f382aa5200511b.1379641901.git.joe@perches.com>
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
On 20/09/13 04:53, Joe Perches wrote:
> s/framebugger/framebuffer/
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/video/arkfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/arkfb.c b/drivers/video/arkfb.c
> index ee0f1a1..b13f3f2 100644
> --- a/drivers/video/arkfb.c
> +++ b/drivers/video/arkfb.c
> @@ -1048,7 +1048,7 @@ static int ark_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
>
> rc = register_framebuffer(info);
> if (rc < 0) {
> - dev_err(info->device, "cannot register framebugger\n");
> + dev_err(info->device, "cannot register framebuffer\n");
> goto err_reg_fb;
> }
>
>
Thanks, queued for 3.13. Although I have to say I kinda like the sound
of framebugger.
Tom
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [patch 1/2] backlight: lm3630: signedness bug in lm3630a_chip_init()
From: Tomi Valkeinen @ 2013-09-26 9:43 UTC (permalink / raw)
To: linux-fbdev
In-Reply-To: <20130925085451.GA6661@elgon.mountain>
[-- Attachment #1: Type: text/plain, Size: 811 bytes --]
On 25/09/13 11:54, Dan Carpenter wrote:
> "rval" needs to be signed for the error handling to work.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
> index c63f918..65392f9 100644
> --- a/drivers/video/backlight/lm3630a_bl.c
> +++ b/drivers/video/backlight/lm3630a_bl.c
> @@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip)
> /* interrupt handling */
> static void lm3630a_delayed_func(struct work_struct *work)
> {
> - unsigned int rval;
> + int rval;
> struct lm3630a_chip *pchip;
>
> pchip = container_of(work, struct lm3630a_chip, work.work);
>
There's no drivers/video/backlight/lm3630a_bl.c in v3.12. Which kernel
is this for?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH 1/2] video: of: display_timing: correct display-timings node finding
From: Tomi Valkeinen @ 2013-09-26 9:37 UTC (permalink / raw)
To: Andrzej Hajda, FRAMEBUFFER LAYER
Cc: Kyungmin Park, Jean-Christophe Plagniol-Villard, dri-devel
In-Reply-To: <1380109892-13040-2-git-send-email-a.hajda@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 510 bytes --]
On 25/09/13 14:51, Andrzej Hajda wrote:
> of_get_display_timing(s) use of_find_node_by_name
> to get child node, this is incorrect, of_get_child_by_name
> should be used instead. The patch fixes it.
> Small typo is also corrected.
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/video/of_display_timing.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Thanks, queuing for 3.12 fixes.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH 2/2] video: of: display_timing: remove broken of_display_timings_exist
From: Tomi Valkeinen @ 2013-09-26 9:37 UTC (permalink / raw)
To: Andrzej Hajda
Cc: FRAMEBUFFER LAYER, Jean-Christophe Plagniol-Villard,
Kyungmin Park, dri-devel
In-Reply-To: <1380109892-13040-3-git-send-email-a.hajda@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]
On 25/09/13 14:51, Andrzej Hajda wrote:
> of_display_timings_exist is implemented incorrectly.
> It tries to find property instead of node.
> The function is not used anyway so the patch removes it.
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/video/of_display_timing.c | 20 --------------------
> include/video/of_display_timing.h | 1 -
> 2 files changed, 21 deletions(-)
Fix by removal? =).
Wouldn't it be better to fix the function? It's not used currently, but
the whole display-timings stuff is still quite new. One could use
of_get_display_timings() to check for the existence of timings, but that
function will print an error if no timings are found.
Then again, what would be the case where you want to check if the
timings exist... I'd presume that there either has to be timings or
there are no timings.
So, I don't know. Any else has opinions whether to remove or fix the
function?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH 1/4] video: vfb: Remove incorrect check
From: Tomi Valkeinen @ 2013-09-26 9:10 UTC (permalink / raw)
To: linux-fbdev
In-Reply-To: <1380110579-3665-1-git-send-email-sachin.kamat@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
On 25/09/13 15:02, Sachin Kamat wrote:
> 'yoffset' is unsigned and hence cannot be less than 0.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/video/vfb.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/vfb.c b/drivers/video/vfb.c
> index ee5985e..ea2b523 100644
> --- a/drivers/video/vfb.c
> +++ b/drivers/video/vfb.c
> @@ -390,9 +390,8 @@ static int vfb_pan_display(struct fb_var_screeninfo *var,
> struct fb_info *info)
> {
> if (var->vmode & FB_VMODE_YWRAP) {
> - if (var->yoffset < 0
> - || var->yoffset >= info->var.yres_virtual
> - || var->xoffset)
> + if (var->yoffset >= info->var.yres_virtual ||
> + var->xoffset)
> return -EINVAL;
> } else {
> if (var->xoffset + info->var.xres > info->var.xres_virtual ||
>
Thanks, queueng the series for 3.13.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH 1/6] video: udlfb: Use NULL instead of 0
From: Tomi Valkeinen @ 2013-09-26 8:50 UTC (permalink / raw)
To: linux-fbdev
In-Reply-To: <1380108594-19090-1-git-send-email-sachin.kamat@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
On 25/09/13 14:29, Sachin Kamat wrote:
> new_back is a pointer. Use NULL instead of 0.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Bernie Thompson <bernie@plugable.com>
> ---
> drivers/video/udlfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c
> index d2e5bc3..025f14e 100644
> --- a/drivers/video/udlfb.c
> +++ b/drivers/video/udlfb.c
> @@ -1166,7 +1166,7 @@ static int dlfb_realloc_framebuffer(struct dlfb_data *dev, struct fb_info *info)
> int new_len;
> unsigned char *old_fb = info->screen_base;
> unsigned char *new_fb;
> - unsigned char *new_back = 0;
> + unsigned char *new_back = NULL;
>
> pr_warn("Reallocating framebuffer. Addresses will change!\n");
>
>
Thanks, queuing this series for 3.13.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH 1/2] backlight: l4f00242t03: Remove redundant spi_set_drvdata
From: Tomi Valkeinen @ 2013-09-26 8:48 UTC (permalink / raw)
To: linux-fbdev
In-Reply-To: <1379659133-18799-1-git-send-email-sachin.kamat@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 795 bytes --]
On 20/09/13 09:38, Sachin Kamat wrote:
> Driver core sets driver data to NULL upon failure or remove.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/video/backlight/l4f00242t03.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
> index a35a38c..59eebe0 100644
> --- a/drivers/video/backlight/l4f00242t03.c
> +++ b/drivers/video/backlight/l4f00242t03.c
> @@ -244,7 +244,6 @@ static int l4f00242t03_remove(struct spi_device *spi)
>
> l4f00242t03_lcd_power_set(priv->ld, FB_BLANK_POWERDOWN);
> lcd_device_unregister(priv->ld);
> - spi_set_drvdata(spi, NULL);
>
> return 0;
> }
>
Thanks, queuing this and the second patch for 3.13.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH] neofb: fix error return code in neofb_probe()
From: Tomi Valkeinen @ 2013-09-26 8:46 UTC (permalink / raw)
To: linux-fbdev
In-Reply-To: <CAPgLHd8sm1rhuuG7TJqAfWesiSDf6MaM4E4VCrrWXGziLEiYVA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]
On 23/09/13 18:00, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/video/neofb.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/neofb.c b/drivers/video/neofb.c
> index 891b0bf..2a3e5bd 100644
> --- a/drivers/video/neofb.c
> +++ b/drivers/video/neofb.c
> @@ -2075,6 +2075,7 @@ static int neofb_probe(struct pci_dev *dev, const struct pci_device_id *id)
> if (!fb_find_mode(&info->var, info, mode_option, NULL, 0,
> info->monspecs.modedb, 16)) {
> printk(KERN_ERR "neofb: Unable to find usable video mode.\n");
> + err = -EINVAL;
> goto err_map_video;
> }
>
> @@ -2097,7 +2098,8 @@ static int neofb_probe(struct pci_dev *dev, const struct pci_device_id *id)
> info->fix.smem_len >> 10, info->var.xres,
> info->var.yres, h_sync / 1000, h_sync % 1000, v_sync);
>
> - if (fb_alloc_cmap(&info->cmap, 256, 0) < 0)
> + err = fb_alloc_cmap(&info->cmap, 256, 0);
> + if (err < 0)
> goto err_map_video;
>
> err = register_framebuffer(info);
>
Thanks, queuing for 3.12 fixes.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH] s3fb: fix error return code in s3_pci_probe()
From: Tomi Valkeinen @ 2013-09-26 8:45 UTC (permalink / raw)
To: linux-fbdev
In-Reply-To: <CAPgLHd_wsqGQ2eSnKY6SzGan0fZLZJWyN03A+_aFmaQ51q73AQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]
On 23/09/13 18:00, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return -EINVAL when virtual vertical size smaller than real
> instead of 0, as done elsewhere in this function. Also remove dup code.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/video/s3fb.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/video/s3fb.c b/drivers/video/s3fb.c
> index 47ca86c..d838ba8 100644
> --- a/drivers/video/s3fb.c
> +++ b/drivers/video/s3fb.c
> @@ -1336,14 +1336,7 @@ static int s3_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
> (info->var.bits_per_pixel * info->var.xres_virtual);
> if (info->var.yres_virtual < info->var.yres) {
> dev_err(info->device, "virtual vertical size smaller than real\n");
> - goto err_find_mode;
> - }
> -
> - /* maximize virtual vertical size for fast scrolling */
> - info->var.yres_virtual = info->fix.smem_len * 8 /
> - (info->var.bits_per_pixel * info->var.xres_virtual);
> - if (info->var.yres_virtual < info->var.yres) {
> - dev_err(info->device, "virtual vertical size smaller than real\n");
> + rc = -EINVAL;
> goto err_find_mode;
> }
>
>
Thanks, queuing for 3.12 fixes.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH] video: mmp: drop needless devm cleanup
From: Tomi Valkeinen @ 2013-09-26 8:43 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <1379952790-13202-1-git-send-email-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
On 23/09/13 19:13, Uwe Kleine-König wrote:
> The nice thing about devm_* is that the driver doesn't need to free the
> resources but the driver core takes care about that. This also
> simplifies the error path quite a bit and removes the wrong check for a
> clock pointer being NULL.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/video/mmp/hw/mmp_ctrl.c | 17 ++---------------
> 1 file changed, 2 insertions(+), 15 deletions(-)
>
Thanks, queuing for 3.12 fixes.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH] OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier
From: Tomi Valkeinen @ 2013-09-26 8:36 UTC (permalink / raw)
To: Mark Brown
Cc: Jean-Christophe Plagniol-Villard, linux-fbdev, linux-omap,
linaro-kernel, Mark Brown
In-Reply-To: <1380108661-22702-1-git-send-email-broonie@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
On 25/09/13 14:31, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> The DSI-CM driver uses the backlight class so needs to build depend on it.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> drivers/video/omap2/displays-new/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/omap2/displays-new/Kconfig b/drivers/video/omap2/displays-new/Kconfig
> index 6c90885..10b25e7 100644
> --- a/drivers/video/omap2/displays-new/Kconfig
> +++ b/drivers/video/omap2/displays-new/Kconfig
> @@ -35,6 +35,7 @@ config DISPLAY_PANEL_DPI
>
> config DISPLAY_PANEL_DSI_CM
> tristate "Generic DSI Command Mode Panel"
> + depends on BACKLIGHT_CLASS_DEVICE
> help
> Driver for generic DSI command mode panels.
>
>
Thanks, I'll queue for 3.12 fixes.
I wish we could "select" instead of "depends on"...
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH] OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier
From: Jingoo Han @ 2013-09-26 0:59 UTC (permalink / raw)
To: 'Mark Brown', 'Tomi Valkeinen',
'Jean-Christophe Plagniol-Villard'
Cc: linux-fbdev, linux-omap, linaro-kernel, 'Mark Brown',
'Jingoo Han'
In-Reply-To: <1380108661-22702-1-git-send-email-broonie@kernel.org>
On Wednesday, September 25, 2013 8:31 PM, Mark Brown wrote:
>
> From: Mark Brown <broonie@linaro.org>
>
> The DSI-CM driver uses the backlight class so needs to build depend on it.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
I checked that the following build errors are removed.
drivers/video/omap2/displays-new/panel-dsi-cm.c:1257: undefined reference to `backlight_device_register'
drivers/video/omap2/displays-new/panel-dsi-cm.c:1283: undefined reference to `backlight_device_unregister'
drivers/built-in.o: In function `dsicm_remove':
drivers/video/omap2/displays-new/panel-dsi-cm.c:1309: undefined reference to `backlight_device_unregister'
Thank you.
Best regards,
Jingoo Han
> ---
> drivers/video/omap2/displays-new/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/omap2/displays-new/Kconfig b/drivers/video/omap2/displays-new/Kconfig
> index 6c90885..10b25e7 100644
> --- a/drivers/video/omap2/displays-new/Kconfig
> +++ b/drivers/video/omap2/displays-new/Kconfig
> @@ -35,6 +35,7 @@ config DISPLAY_PANEL_DPI
>
> config DISPLAY_PANEL_DSI_CM
> tristate "Generic DSI Command Mode Panel"
> + depends on BACKLIGHT_CLASS_DEVICE
> help
> Driver for generic DSI command mode panels.
>
> --
> 1.8.4.rc3
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox