* linux-firmware: Duplicate links
@ 2024-02-02 14:40 Juerg Haefliger
2024-02-02 15:17 ` Stefan Binding
0 siblings, 1 reply; 2+ messages in thread
From: Juerg Haefliger @ 2024-02-02 14:40 UTC (permalink / raw)
To: sbinding; +Cc: linux-firmware
[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]
Stefan,
Your commit [1] introduced duplicate symlinks in WHENCE pointing to different
binaries:
Link: cirrus/cs35l41-dsp1-spk-prot-103c8ca7.wmfw -> cs35l41/v6.83.0/halo_cspl_RAM_revB2_29.85.0.wmfw
Link: cirrus/cs35l41-dsp1-spk-cali-103c8ca7.wmfw -> cs35l41/v6.83.0/halo_cspl_RAM_revB2_29.85.0.wmfw
Link: cirrus/cs35l41-dsp1-spk-prot-103c8ca7.wmfw -> cs35l41-dsp1-spk-prot-103c8ca4.bin
Link: cirrus/cs35l41-dsp1-spk-cali-103c8ca7.wmfw -> cs35l41-dsp1-spk-cali-103c8ca4.bin
Link: cirrus/cs35l41-dsp1-spk-prot-103c8ca7.wmfw -> cs35l41/v6.83.0/halo_cspl_RAM_revB2_29.85.0.wmfw
Link: cirrus/cs35l41-dsp1-spk-cali-103c8ca7.wmfw -> cs35l41/v6.83.0/halo_cspl_RAM_revB2_29.85.0.wmfw
Which two are the correct ones?
...Juerg
[1]
commit 4f498d09a4a6a905f231a52f33886f8a5d22d5de
Author: Stefan Binding <sbinding@opensource.cirrus.com>
Date: Fri Oct 20 14:58:26 2023 +0100
linux-firmware: Add firmware for Cirrus CS35L41 on HP G11 Laptops
Support for 3 laptops using CS35L41.
Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: linux-firmware: Duplicate links
2024-02-02 14:40 linux-firmware: Duplicate links Juerg Haefliger
@ 2024-02-02 15:17 ` Stefan Binding
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Binding @ 2024-02-02 15:17 UTC (permalink / raw)
To: 'Juerg Haefliger'; +Cc: linux-firmware, patches
Hi,
Apologies for this.
I currently have a fix for this locally, that I'm planning to send
upstream shortly.
Thanks,
Stefan
> -----Original Message-----
> From: Juerg Haefliger <juerg.haefliger@canonical.com>
> Sent: Friday, February 2, 2024 2:41 PM
> To: sbinding@opensource.cirrus.com
> Cc: linux-firmware@kernel.org
> Subject: linux-firmware: Duplicate links
>
> Stefan,
>
> Your commit [1] introduced duplicate symlinks in WHENCE pointing to
> different
> binaries:
>
> Link: cirrus/cs35l41-dsp1-spk-prot-103c8ca7.wmfw ->
> cs35l41/v6.83.0/halo_cspl_RAM_revB2_29.85.0.wmfw
> Link: cirrus/cs35l41-dsp1-spk-cali-103c8ca7.wmfw ->
> cs35l41/v6.83.0/halo_cspl_RAM_revB2_29.85.0.wmfw
>
> Link: cirrus/cs35l41-dsp1-spk-prot-103c8ca7.wmfw ->
cs35l41-dsp1-spk-
> prot-103c8ca4.bin
> Link: cirrus/cs35l41-dsp1-spk-cali-103c8ca7.wmfw ->
cs35l41-dsp1-spk-
> cali-103c8ca4.bin
>
> Link: cirrus/cs35l41-dsp1-spk-prot-103c8ca7.wmfw ->
> cs35l41/v6.83.0/halo_cspl_RAM_revB2_29.85.0.wmfw
> Link: cirrus/cs35l41-dsp1-spk-cali-103c8ca7.wmfw ->
> cs35l41/v6.83.0/halo_cspl_RAM_revB2_29.85.0.wmfw
>
> Which two are the correct ones?
>
> ...Juerg
>
>
> [1]
> commit 4f498d09a4a6a905f231a52f33886f8a5d22d5de
> Author: Stefan Binding <sbinding@opensource.cirrus.com>
> Date: Fri Oct 20 14:58:26 2023 +0100
>
> linux-firmware: Add firmware for Cirrus CS35L41 on HP G11
Laptops
>
> Support for 3 laptops using CS35L41.
>
> Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-02 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-02 14:40 linux-firmware: Duplicate links Juerg Haefliger
2024-02-02 15:17 ` Stefan Binding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox