From: Emil Velikov via B4 Relay <devnull+emil.l.velikov.gmail.com@kernel.org>
To: linux-firmware@kernel.org
Cc: Emil Velikov <emil.l.velikov@gmail.com>,
Juerg Haefliger <juerg.haefliger@canonical.com>
Subject: [PATCH v2 00/16] Range of copy-firmware/check_whence fixes
Date: Mon, 23 Sep 2024 14:09:28 +0100 [thread overview]
Message-ID: <20240923-misc-fixes-v2-0-397f23443628@gmail.com> (raw)
Hello all,
With the latest python 3.12 check_whence.py started throwing some
warnings. The more I looked around, the more loose ends and bugs reared
their (ugly) heads.
In this series:
- check_whence.py: sort the filenames, use consistent variable names
- check_whence.py: fix links-to-links and band them
- editorconfig: add the config and fix the yaml+sh indentation
- copy-firmware.sh: factor out dedup fix broken ad-hoc symlink handling
- copy-firmware.sh: remove the hacky argument injection
- copy-firmware.sh: warn if the destination folder is NOT empty
- copy-firmware.sh: call ./check_whence.py and remove the dead code
The series is a mix of cosmetics (style, names), existing bug fixes and
trying loose ends. I'm happy to split it in sub-series, as per your
suggestions.
As always, input is highly appreciated. Thanks o/
To: linux-firmware@kernel.org
Changes in v2:
- Commit message tweaks
- Correct a few flipped test checks
- Rename deduplicate-firmware.sh to dedup-firmware.sh
- Change line width (editorconfig) to 90
- Properly handle destdir
- Link to v1: https://lore.kernel.org/r/20240922-misc-fixes-v1-0-8c6e52997c94@gmail.com
---
Emil Velikov (16):
check_whence.py: use consistent naming
check_whence.py: ban link-to-a-link
check_whence.py: LC_ALL=C sort -u the filelist
check_whence.py: annotate replacement strings as raw
editorconfig: add initial config file
Style update yaml files
copy-firmware.sh: flesh out and fix dedup-firmware.sh
Revert "copy-firmware: Support additional compressor options"
copy-firmware.sh: reset and consistently handle destdir
copy-firmware.sh: fix indentation
copy-firmware.sh: add err() helper
copy-firmware.sh: warn if the destination folder is not empty
copy-firmware.sh: call ./check_whence.py before parsing the file
copy-firmware.sh: remove no longer reachable test -f
copy-firmware.sh: remove no longer reachable test -L
copy-firmware.sh: rename variables in symlink hanlding
.editorconfig | 21 +++++++++
.gitlab-ci.yml | 2 +-
.pre-commit-config.yaml | 38 ++++++++--------
Makefile | 9 ++--
WHENCE | 14 +++---
check_whence.py | 42 +++++++++++-------
copy-firmware.sh | 113 +++++++++++++-----------------------------------
dedup-firmware.sh | 52 ++++++++++++++++++++++
8 files changed, 162 insertions(+), 129 deletions(-)
---
base-commit: 6c88d9b8253b8ec6df701a551a56438ea2e5bacf
change-id: 20240922-misc-fixes-8a13acc71a93
Best regards,
--
Emil Velikov <emil.l.velikov@gmail.com>
next reply other threads:[~2024-09-23 13:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 13:09 Emil Velikov via B4 Relay [this message]
2024-09-23 13:09 ` [PATCH v2 01/16] check_whence.py: use consistent naming Emil Velikov via B4 Relay
2024-09-23 13:09 ` [PATCH v2 02/16] check_whence.py: ban link-to-a-link Emil Velikov via B4 Relay
2024-09-23 13:09 ` [PATCH v2 03/16] check_whence.py: LC_ALL=C sort -u the filelist Emil Velikov via B4 Relay
2024-09-23 13:09 ` [PATCH v2 04/16] check_whence.py: annotate replacement strings as raw Emil Velikov via B4 Relay
2024-09-23 13:09 ` [PATCH v2 05/16] editorconfig: add initial config file Emil Velikov via B4 Relay
2024-09-23 13:09 ` [PATCH v2 06/16] Style update yaml files Emil Velikov via B4 Relay
2024-09-23 13:09 ` [PATCH v2 07/16] copy-firmware.sh: flesh out and fix dedup-firmware.sh Emil Velikov via B4 Relay
2024-09-23 13:09 ` [PATCH v2 08/16] Revert "copy-firmware: Support additional compressor options" Emil Velikov via B4 Relay
2024-09-23 13:09 ` [PATCH v2 09/16] copy-firmware.sh: reset and consistently handle destdir Emil Velikov via B4 Relay
2024-09-23 13:09 ` [PATCH v2 10/16] copy-firmware.sh: fix indentation Emil Velikov via B4 Relay
2024-09-23 13:09 ` [PATCH v2 11/16] copy-firmware.sh: add err() helper Emil Velikov via B4 Relay
2024-09-23 13:09 ` [PATCH v2 12/16] copy-firmware.sh: warn if the destination folder is not empty Emil Velikov via B4 Relay
2024-09-23 13:09 ` [PATCH v2 13/16] copy-firmware.sh: call ./check_whence.py before parsing the file Emil Velikov via B4 Relay
2024-09-23 13:09 ` [PATCH v2 14/16] copy-firmware.sh: remove no longer reachable test -f Emil Velikov via B4 Relay
2024-09-23 13:09 ` [PATCH v2 15/16] copy-firmware.sh: remove no longer reachable test -L Emil Velikov via B4 Relay
2024-09-23 13:09 ` [PATCH v2 16/16] copy-firmware.sh: rename variables in symlink hanlding Emil Velikov via B4 Relay
2024-10-10 3:25 ` [PATCH v2 00/16] Range of copy-firmware/check_whence fixes Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240923-misc-fixes-v2-0-397f23443628@gmail.com \
--to=devnull+emil.l.velikov.gmail.com@kernel.org \
--cc=emil.l.velikov@gmail.com \
--cc=juerg.haefliger@canonical.com \
--cc=linux-firmware@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox