Re: [PATCH v2 00/16] Range of copy-firmware/check_whence fixes

[Mario Limonciello <superm1@gmail.com>]

On 9/23/24 08:09, Emil Velikov via B4 Relay wrote:
> Hello all,
> 
> With the latest python 3.12 check_whence.py started throwing some
> warnings. The more I looked around, the more loose ends and bugs reared
> their (ugly) heads.
> 
> In this series:
>   - check_whence.py: sort the filenames, use consistent variable names
>   - check_whence.py: fix links-to-links and band them
>   - editorconfig: add the config and fix the yaml+sh indentation
>   - copy-firmware.sh: factor out dedup fix broken ad-hoc symlink handling
>   - copy-firmware.sh: remove the hacky argument injection
>   - copy-firmware.sh: warn if the destination folder is NOT empty
>   - copy-firmware.sh: call ./check_whence.py and remove the dead code
> 
> The series is a mix of cosmetics (style, names), existing bug fixes and
> trying loose ends. I'm happy to split it in sub-series, as per your
> suggestions.
> 
> As always, input is highly appreciated. Thanks o/
> 
> To: linux-firmware@kernel.org

Hi,

I passed this into a MR in Gitlab and it fails CI.

https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/316

Can you please run `make check` before submitting again?

Also ideally please submit a MR instead of an email.  Then you can force 
push until CI passes or take into account any feedback.

Thanks!
> 
> Changes in v2:
> - Commit message tweaks
> - Correct a few flipped test checks
> - Rename deduplicate-firmware.sh to dedup-firmware.sh
> - Change line width (editorconfig) to 90
> - Properly handle destdir
> - Link to v1: https://lore.kernel.org/r/20240922-misc-fixes-v1-0-8c6e52997c94@gmail.com
> 
> ---
> Emil Velikov (16):
>        check_whence.py: use consistent naming
>        check_whence.py: ban link-to-a-link
>        check_whence.py: LC_ALL=C sort -u the filelist
>        check_whence.py: annotate replacement strings as raw
>        editorconfig: add initial config file
>        Style update yaml files
>        copy-firmware.sh: flesh out and fix dedup-firmware.sh
>        Revert "copy-firmware: Support additional compressor options"
>        copy-firmware.sh: reset and consistently handle destdir
>        copy-firmware.sh: fix indentation
>        copy-firmware.sh: add err() helper
>        copy-firmware.sh: warn if the destination folder is not empty
>        copy-firmware.sh: call ./check_whence.py before parsing the file
>        copy-firmware.sh: remove no longer reachable test -f
>        copy-firmware.sh: remove no longer reachable test -L
>        copy-firmware.sh: rename variables in symlink hanlding
> 
>   .editorconfig           |  21 +++++++++
>   .gitlab-ci.yml          |   2 +-
>   .pre-commit-config.yaml |  38 ++++++++--------
>   Makefile                |   9 ++--
>   WHENCE                  |  14 +++---
>   check_whence.py         |  42 +++++++++++-------
>   copy-firmware.sh        | 113 +++++++++++++-----------------------------------
>   dedup-firmware.sh       |  52 ++++++++++++++++++++++
>   8 files changed, 162 insertions(+), 129 deletions(-)
> ---
> base-commit: 6c88d9b8253b8ec6df701a551a56438ea2e5bacf
> change-id: 20240922-misc-fixes-8a13acc71a93
> 
> Best regards,