From: David Sterba <dsterba@suse.cz>
To: Boris Burkov <boris@bur.io>
Cc: linux-fscrypt@vger.kernel.org, linux-btrfs@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH v2] btrfs: send: add support for fs-verity
Date: Tue, 2 Aug 2022 16:58:52 +0200 [thread overview]
Message-ID: <20220802145852.GP13489@twin.jikos.cz> (raw)
In-Reply-To: <9bfbf3b43d2c2663d2e3f196810288fd83c0b52e.1659031503.git.boris@bur.io>
On Thu, Jul 28, 2022 at 11:11:42AM -0700, Boris Burkov wrote:
> --- a/fs/btrfs/send.h
> +++ b/fs/btrfs/send.h
> @@ -92,8 +92,11 @@ enum btrfs_send_cmd {
> BTRFS_SEND_C_ENCODED_WRITE = 25,
> BTRFS_SEND_C_MAX_V2 = 25,
>
> + /* Version 3 */
> + BTRFS_SEND_C_ENABLE_VERITY = 26,
Regarding the name, same name for ioctl and command is a good idea, for
potential future verity extensions we could add more and having plain
'VERITY' would not be ideal. The other ioctl is 'measure', so I thought
of something like consistency check during the stream, "verify this
file before continuing".
The command names are either imperative or descriptive, so alternative
name could be VERITY_RECORD or VERITY_DESC that matches the data stored,
the BTRFS_VERITY_DESC_ITEM_KEY .
prev parent reply other threads:[~2022-08-02 15:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 18:11 [PATCH v2] btrfs: send: add support for fs-verity Boris Burkov
2022-07-31 10:35 ` kernel test robot
2022-08-02 14:42 ` David Sterba
2022-07-31 14:19 ` kernel test robot
2022-08-02 14:35 ` David Sterba
2022-08-02 14:58 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220802145852.GP13489@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=boris@bur.io \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox