From: Eric Dumazet <eric.dumazet@gmail.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: Nick Piggin <npiggin@suse.de>, Jens Axboe <jaxboe@fusionio.com>,
Dan Carpenter <error27@gmail.com>,
Matthew Wilcox <matthew@wil.cx>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch v2] fcntl: return -EFAULT if copy_to_user fails
Date: Thu, 03 Jun 2010 15:42:43 +0200 [thread overview]
Message-ID: <1275572563.2456.37.camel@edumazet-laptop> (raw)
In-Reply-To: <4C07AD0C.8090409@oss.ntt.co.jp>
Le jeudi 03 juin 2010 à 22:24 +0900, Takuya Yoshikawa a écrit :
> (2010/06/03 22:10), Nick Piggin wrote:
> > On Thu, Jun 03, 2010 at 02:38:03PM +0200, Eric Dumazet wrote:
> >> This is really ugly.
> >>
> >> static inline int sec_copy_to_user(arg1, arg2, arg3)
> >> {
> >> int res = copy_to_user(arg1, arg2, arg3);
> >>
> >> return (res> 0) ? -EFAULT : res;
> >> }
> >
> > It would be unfortunate if it adds more confusion. I'd prefer to have
> > a sufficiently different name. memcpy_to_user/memcpy_from_user
> > perhaps?
>
> Then, and memclear_user() ?
>
> >
>
We are interested by the fact that full copy is done, so maybe use the
'full' prefix ?
fullcopy_to_user() , fullclear_user() ?
next prev parent reply other threads:[~2010-06-03 13:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 10:04 [patch] fcntl: return -EFAULT if copy_to_user fails Dan Carpenter
2010-06-03 10:22 ` Takuya Yoshikawa
[not found] ` <4C07826A.6060302@oss.ntt.co.jp>
2010-06-03 10:35 ` [patch v2] " Dan Carpenter
2010-06-03 10:42 ` Peter Zijlstra
2010-06-03 11:59 ` Jens Axboe
[not found] ` <4C07990A.8080508@fusionio.com>
2010-06-03 12:16 ` Takuya Yoshikawa
2010-06-03 12:38 ` Eric Dumazet
2010-06-03 13:10 ` Nick Piggin
2010-06-03 13:24 ` Takuya Yoshikawa
2010-06-03 13:42 ` Eric Dumazet [this message]
2010-06-03 12:45 ` Dan Carpenter
2010-06-04 11:14 ` Dan Carpenter
2010-06-03 12:45 ` [patch] " Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275572563.2456.37.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=error27@gmail.com \
--cc=gregkh@suse.de \
--cc=jaxboe@fusionio.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=npiggin@suse.de \
--cc=oleg@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox