Re: [PATCH] [f2fs-tools] mkfs: Make HDIO_GETGEO ioctl optional

[Jaegeuk Kim <jaegeuk.kim@samsung.com>]

[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]

2012-12-11 (화), 23:08 -0300, Ezequiel Garcia:
> From: Ezequiel Garcia <ezequiel@free-electrons.com>
> 
> Some block devices don't implement HDIO_GETGEP ioctl;
> loop device being a notable example.
> Without this patch, it's not possible to make a f2fs
> on a file mounted over a loop device.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@free-electrons.com>
> ---
>  mkfs/f2fs_format.c |    9 ++++-----
>  1 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
> index d3e1d0c..b542db5 100644
> --- a/mkfs/f2fs_format.c
> +++ b/mkfs/f2fs_format.c
> @@ -262,11 +262,10 @@ static int8_t f2fs_get_device_info()
>  			return -1;
>  		}
>  
> -		if (ioctl(fd, HDIO_GETGEO, &geom) < 0) {
> -			printf("\n\tError: Cannot get the device geometry\n");
> -			return -1;
> -		}
> -		f2fs_params.start_sector = geom.start;
> +		if (ioctl(fd, HDIO_GETGEO, &geom) < 0)
> +			f2fs_params.start_sector = 0;
> +		else
> +			f2fs_params.start_sector = geom.start;
>  	}
>  	else {
>  		printf("\n\n\tError: Volume type is not supported!!!\n");

Merged, thanks. :)

-- 
Jaegeuk Kim
Samsung

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]