From: Christoph Hellwig <hch@infradead.org>
To: Steve Lord <lord@sgi.com>
Cc: Anton Altaparmakov <aia21@cantab.net>,
Jan Harkes <jaharkes@cs.cmu.edu>,
Alexander Viro <viro@math.psu.edu>,
linux-fsdevel@vger.kernel.org
Subject: Re: iget4/read_inode2 race in get_new_inode
Date: Mon, 29 Apr 2002 19:39:41 +0100 [thread overview]
Message-ID: <20020429193941.A25992@infradead.org> (raw)
In-Reply-To: <1020105046.16224.246.camel@jen.americas.sgi.com>; from lord@sgi.com on Mon, Apr 29, 2002 at 01:30:46PM -0500
On Mon, Apr 29, 2002 at 01:30:46PM -0500, Steve Lord wrote:
> Here for the record is that code - based by the way on some suggestions
> Al made here to Chris Mason about other ways of doing things than read_inode2
>
> Any comments Al, and Anton, what were the cleanups and renames? The
> EXPORT_SYMBOL parts of this are missing right now, they should be in
> inode.c not ksyms.c where we currently have them.
* kill ->read_inode2 entirely, reiserfs can be directly converted to
icreate()
* kill populate_inode, it is small and has only one user
* either remove (_)unlock_new_inode entirely and let the callers do the
two lines themselves or make it a #define in fs.h (unfortunately an
inline isn't possible there due to missing wake_up() declaration)
next prev parent reply other threads:[~2002-04-29 18:39 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-29 16:14 iget4/read_inode2 race in get_new_inode Jan Harkes
2002-04-29 16:48 ` Jan Harkes
2002-04-29 17:49 ` Alexander Viro
2002-04-29 19:34 ` Anton Altaparmakov
2002-04-29 19:39 ` Anton Altaparmakov
2002-04-29 19:41 ` Steve Lord
2002-04-29 19:51 ` Anton Altaparmakov
2002-04-29 19:51 ` Christoph Hellwig
2002-04-29 20:07 ` Anton Altaparmakov
2002-04-29 20:13 ` Christoph Hellwig
2002-04-29 20:24 ` Jan Harkes
2002-04-29 20:28 ` Anton Altaparmakov
2002-04-29 20:20 ` Jan Harkes
2002-04-29 20:31 ` Anton Altaparmakov
2002-04-29 20:48 ` Steve Lord
2002-04-29 20:58 ` Jan Harkes
2002-04-29 21:04 ` Steve Lord
2002-04-29 21:34 ` Anton Altaparmakov
2002-04-29 22:36 ` Alexander Viro
2002-04-29 22:54 ` Jan Harkes
2002-04-29 17:18 ` Anton Altaparmakov
2002-04-29 17:33 ` Jan Harkes
2002-04-29 17:44 ` Alexander Viro
2002-04-29 18:02 ` Jan Harkes
2002-04-29 18:22 ` Anton Altaparmakov
2002-04-29 18:30 ` Steve Lord
2002-04-29 18:39 ` Christoph Hellwig [this message]
2002-04-29 19:20 ` Steve Lord
2002-04-29 19:52 ` Christoph Hellwig
2002-04-29 22:02 ` Chris Mason
2002-04-29 19:12 ` Jan Harkes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020429193941.A25992@infradead.org \
--to=hch@infradead.org \
--cc=aia21@cantab.net \
--cc=jaharkes@cs.cmu.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lord@sgi.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox