public inbox for linux-fsdevel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@muc.de>
To: marcelo.tosatti@cyclades.com.br
Cc: linux-fsdevel@vger.kernel.org
Subject: [PATCH] Mask out O_LARGEFILE in F_GETFL
Date: Thu, 25 Sep 2003 07:25:08 +0200	[thread overview]
Message-ID: <20030925052508.GA2374@averell> (raw)


This fixes a test in the LSB test suite. 

The kernel sets O_LARGEFILE implicitely on 64bit hosts.
According to POSIX it should not appear on F_GETFL then. Just mask it out
always. 

This will also mask it out for explicitely set O_LARGEFILE, but that seems
to be ok.

Any flames for this please to the POSIX comittee, not to me.

-Andi

diff -X ../../KDIFX -burpN linux-2.4.23-pre5/fs/fcntl.c linux-merge/fs/fcntl.c
--- linux-2.4.23-pre5/fs/fcntl.c	2002-11-30 00:37:11.000000000 +0100
+++ linux-merge/fs/fcntl.c	2002-11-30 05:22:20.000000000 +0100
@@ -270,7 +270,7 @@ static long do_fcntl(unsigned int fd, un
 			set_close_on_exec(fd, arg&1);
 			break;
 		case F_GETFL:
-			err = filp->f_flags;
+			err = filp->f_flags & ~O_LARGEFILE;
 			break;
 		case F_SETFL:
 			lock_kernel();


             reply	other threads:[~2003-09-25  5:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-25  5:25 Andi Kleen [this message]
2003-10-01 13:24 ` [PATCH] Mask out O_LARGEFILE in F_GETFL Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030925052508.GA2374@averell \
    --to=ak@muc.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox