From: viro@parcelfarce.linux.theplanet.co.uk
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Matthew Wilcox <willy@debian.org>,
Steve French <smfltc@us.ibm.com>,
linux-cifs-client@cifs.bkbits.net, linux-fsdevel@vger.kernel.org
Subject: Re: fcntl method for file_operations
Date: Thu, 25 Mar 2004 20:31:02 +0000 [thread overview]
Message-ID: <20040325203102.GX31500@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <1080245758.3463.31.camel@lade.trondhjem.org>
On Thu, Mar 25, 2004 at 03:15:58PM -0500, Trond Myklebust wrote:
> I can see his point: fcntl() is second only to ioctl() when it comes to
> interface design. If you want to provide methods/callbacks for each and
> every overloaded subcase, then your "struct file_operations" can quickly
> turn ugly.
And for that very reason we don't _want_ to make it easy to add new
piles of vomit into fcntl(). ioctl() is bad enough; until now fcntl()
was somewhat limited, but typeless method will immediately open the
floodgates.
IOW, my vote is strongly against ->fcntl() - the last thing we need
is yet another multiplexor available to Joe Random Driver-Monkey.
next prev parent reply other threads:[~2004-03-25 20:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-25 18:04 fcntl method for file_operations Steve French
2004-03-25 19:35 ` Matthew Wilcox
2004-03-25 19:55 ` Jamie Lokier
2004-03-25 20:15 ` Trond Myklebust
2004-03-25 20:31 ` viro [this message]
2004-03-25 20:59 ` Trond Myklebust
2004-03-25 20:25 ` Steve French
2004-03-25 20:34 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040325203102.GX31500@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=linux-cifs-client@cifs.bkbits.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=smfltc@us.ibm.com \
--cc=trond.myklebust@fys.uio.no \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox