From: viro@parcelfarce.linux.theplanet.co.uk
To: Steve French <smfltc@us.ibm.com>
Cc: Matthew Wilcox <willy@debian.org>,
linux-cifs-client@lists.samba.org, linux-fsdevel@vger.kernel.org,
Jamie Lokier <jamie@shareable.org>
Subject: Re: fcntl method for file_operations
Date: Thu, 25 Mar 2004 20:34:48 +0000 [thread overview]
Message-ID: <20040325203448.GY31500@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <1080246358.3200.45.camel@stevef95.austin.ibm.com>
On Thu, Mar 25, 2004 at 02:25:58PM -0600, Steve French wrote:
> passed to network filesystems and filesystems without true block
> devices. Current sys_quotactl does
> bdev = lookup_bdev(name)
> then
> get_super(bdev)
>
> rather than looking up the superblock directly from the name (using
> user_path_walk as sys_statfs and other places in the kernel do) so that
> small section of quota.c needs to be modified for non-local and
> deviceless filesystems.
That's not a VFS problem - it's a bad syscall API. Note that statfs(2)
uses pathname of mountpoint (anything on fs, actually). quotactl(2)
uses pathname of _device_. Which is, indeed, a bad idea, but we are
tied by user-visible API here.
prev parent reply other threads:[~2004-03-25 20:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-25 18:04 fcntl method for file_operations Steve French
2004-03-25 19:35 ` Matthew Wilcox
2004-03-25 19:55 ` Jamie Lokier
2004-03-25 20:15 ` Trond Myklebust
2004-03-25 20:31 ` viro
2004-03-25 20:59 ` Trond Myklebust
2004-03-25 20:25 ` Steve French
2004-03-25 20:34 ` viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040325203448.GY31500@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=jamie@shareable.org \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=smfltc@us.ibm.com \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox