From: Christoph Hellwig <hch@infradead.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: hch@lst.de, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/4] new helper: d_obtain_alias
Date: Tue, 9 Sep 2008 11:26:31 -0400 [thread overview]
Message-ID: <20080909152631.GA29279@infradead.org> (raw)
In-Reply-To: <E1Kd38P-0001td-DS@pomaz-ex.szeredi.hu>
On Tue, Sep 09, 2008 at 03:19:57PM +0200, Miklos Szeredi wrote:
> > + * and will be casted to the corresponding NULL or IS_ERR dentry.
> > + */
>
> Mixing NULL with ERR_PTR() seems like a bad idea. It should be either
> one or the other but not both.
It's how the existing interface works. I think we should move to only
ERR_PTR returns, but it's not very high on my todo list.
next prev parent reply other threads:[~2008-09-09 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-11 13:48 [PATCH 2/4] new helper: d_obtain_alias Christoph Hellwig
2008-09-09 13:19 ` Miklos Szeredi
2008-09-09 15:26 ` Christoph Hellwig [this message]
2008-09-11 8:46 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080909152631.GA29279@infradead.org \
--to=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox