From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: vfs: Don't copy mount bind mounts of /proc/<pid>/ns/mnt between namespaces
Date: Mon, 2 Sep 2013 23:40:38 +0300 [thread overview]
Message-ID: <20130902204038.GO19256@mwanda> (raw)
In-Reply-To: <874na3nf07.fsf@xmission.com>
On Mon, Sep 02, 2013 at 01:30:00PM -0700, Eric W. Biederman wrote:
> Dan Carpenter <dan.carpenter@oracle.com> writes:
>
> > Hello Eric W. Biederman,
> >
> > This is a semi-automatic email about new static checker warnings.
> >
> > The patch 4ce5d2b1a8fd: "vfs: Don't copy mount bind mounts of
> > /proc/<pid>/ns/mnt between namespaces" from Mar 30, 2013, leads to
> > the following Smatch complaint:
>
> Semi-autoautomatic reply. The test !q is enough to ensure p is valid
> until p->mnt.mnt_root == q->mnt.mnt_root.
>
> This has been verified through both testing and reading of the code.
>
Why not make the test:
while (1) { ...
regards,
dan carpenter
next prev parent reply other threads:[~2013-09-02 20:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 15:20 vfs: Don't copy mount bind mounts of /proc/<pid>/ns/mnt between namespaces Dan Carpenter
2013-09-02 20:30 ` Eric W. Biederman
2013-09-02 20:40 ` Dan Carpenter [this message]
2013-09-02 21:52 ` Eric W. Biederman
2013-09-02 23:10 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130902204038.GO19256@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox