From: Jiri Slaby <jslaby@suse.cz>
To: viro@zeniv.linux.org.uk
Cc: linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>,
Jeff Layton <jlayton@poochiereds.net>,
"J. Bruce Fields" <bfields@fieldses.org>,
linux-fsdevel@vger.kernel.org
Subject: [PATCH] fs: fcntl, avoid undefined behaviour
Date: Fri, 14 Oct 2016 11:23:41 +0200 [thread overview]
Message-ID: <20161014092342.25546-1-jslaby@suse.cz> (raw)
fcntl(0, F_SETOWN, 0x80000000) triggers:
UBSAN: Undefined behaviour in fs/fcntl.c:118:7
negation of -2147483648 cannot be represented in type 'int':
CPU: 1 PID: 18261 Comm: syz-executor Not tainted 4.8.1-0-syzkaller #1
...
Call Trace:
...
[<ffffffffad8f0868>] ? f_setown+0x1d8/0x200
[<ffffffffad8f19a9>] ? SyS_fcntl+0x999/0xf30
[<ffffffffaed1fb00>] ? entry_SYSCALL_64_fastpath+0x23/0xc1
Fix that by checking the arg parameter properly (against INT_MAX) and
return immediatelly in case it is wrong. No error is returned, the
same as in other cases.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Jeff Layton <jlayton@poochiereds.net>
Cc: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
---
fs/fcntl.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/fs/fcntl.c b/fs/fcntl.c
index 350a2c8cfd28..bfc3b040d956 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -112,6 +112,10 @@ void f_setown(struct file *filp, unsigned long arg, int force)
enum pid_type type;
struct pid *pid;
int who = arg;
+
+ if (arg > INT_MAX)
+ return;
+
type = PIDTYPE_PID;
if (who < 0) {
type = PIDTYPE_PGID;
--
2.10.1
next reply other threads:[~2016-10-14 9:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 9:23 Jiri Slaby [this message]
2016-10-14 9:23 ` [PATCH] fs: pipe, fix undefined behaviour Jiri Slaby
2016-10-14 9:57 ` Vegard Nossum
2016-10-14 11:48 ` [PATCH] fs: fcntl, avoid " Jeff Layton
2016-10-14 13:38 ` J. Bruce Fields
2016-10-24 9:15 ` Jiri Slaby
2016-10-24 11:29 ` Jeff Layton
2016-10-24 11:34 ` Jiri Slaby
2017-06-12 5:03 ` zhong jiang
2017-06-13 9:29 ` Jiri Slaby
2017-06-13 10:02 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161014092342.25546-1-jslaby@suse.cz \
--to=jslaby@suse.cz \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox