From: Jiri Slaby <jslaby@suse.cz>
To: Jeff Layton <jlayton@redhat.com>,
"J. Bruce Fields" <bfields@fieldses.org>
Cc: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: fcntl, avoid undefined behaviour
Date: Mon, 24 Oct 2016 13:34:15 +0200 [thread overview]
Message-ID: <e120880d-52b1-5129-199f-9add4c465f30@suse.cz> (raw)
In-Reply-To: <1477308581.2625.20.camel@redhat.com>
On 10/24/2016, 01:29 PM, Jeff Layton wrote:
> It looks like it lists this as a "may fail" case:
>
> http://pubs.opengroup.org/onlinepubs/9699919799/functions/fcntl.html
>
> [EINVAL]
> The cmd argument is F_SETOWN and the value of the argument
> is not valid as a process or process group identifier.
Huh, my man 3p fcntl only lists [EDEADLK] at that point. (I have 2013
edition opposing to 2016 from the link above)
> IMO, returning an error here is the right thing to do. Either the
> application isn't checking for errors, in which case returning one won't
> matter, or it is, and they probably want to be informed that their
> F_SETOWN didn't do what they expected.
Ok, will do.
--
js
suse labs
next prev parent reply other threads:[~2016-10-24 11:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 9:23 [PATCH] fs: fcntl, avoid undefined behaviour Jiri Slaby
2016-10-14 9:23 ` [PATCH] fs: pipe, fix " Jiri Slaby
2016-10-14 9:57 ` Vegard Nossum
2016-10-14 11:48 ` [PATCH] fs: fcntl, avoid " Jeff Layton
2016-10-14 13:38 ` J. Bruce Fields
2016-10-24 9:15 ` Jiri Slaby
2016-10-24 11:29 ` Jeff Layton
2016-10-24 11:34 ` Jiri Slaby [this message]
2017-06-12 5:03 ` zhong jiang
2017-06-13 9:29 ` Jiri Slaby
2017-06-13 10:02 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e120880d-52b1-5129-199f-9add4c465f30@suse.cz \
--to=jslaby@suse.cz \
--cc=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox