From: Al Viro <viro@ZenIV.linux.org.uk>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Containers <containers@lists.linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] namespace related fixes for 4.10-rc3
Date: Sat, 7 Jan 2017 06:40:13 +0000 [thread overview]
Message-ID: <20170107064012.GI1555@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20170107062952.GH1555@ZenIV.linux.org.uk>
On Sat, Jan 07, 2017 at 06:29:52AM +0000, Al Viro wrote:
> On Sat, Jan 07, 2017 at 06:30:05PM +1300, Eric W. Biederman wrote:
>
> > Eric W. Biederman (3):
> > mnt: Protect the mountpoint hashtable with mount_lock
> ACK
>
> > mnt: Tuck mounts under others instead of creating shadow/side mounts.
>
> NAK; you have reintroduced put_mountpoint() outside of mount lock in there
> and you've got seriously confused umount side of the things.
PS: details are in my reply (admittedly, sent only ~20 minutes
before your pull request) to your patch. Check Message-ID
<20170107050644.GA12074@ZenIV.linux.org.uk>
My apologies for not getting to it yesterday (the patch was posted a couple of
days ago, AFAICS) - I'd been off-net since Wednesday, just got back ;-/
next prev parent reply other threads:[~2017-01-07 6:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 5:30 [GIT PULL] namespace related fixes for 4.10-rc3 Eric W. Biederman
2017-01-07 6:29 ` Al Viro
2017-01-07 6:40 ` Al Viro [this message]
2017-01-10 23:23 ` Eric W. Biederman
2017-01-10 23:25 ` [GIT PULL] namespace related fixes for 4.10-rc4 Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170107064012.GI1555@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox