From: Christian Brauner <brauner@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH v2] fs/buffer: Remove redundant assignment to err
Date: Mon, 3 Apr 2023 18:41:57 +0200 [thread overview]
Message-ID: <20230403-battered-crusher-46d00c43a7a4@brauner> (raw)
In-Reply-To: <ZCr7H9NqkPlmR/jk@casper.infradead.org>
On Mon, Apr 03, 2023 at 05:13:19PM +0100, Matthew Wilcox wrote:
> On Mon, Mar 27, 2023 at 10:10:10AM +0200, Christian Brauner wrote:
> >
> > On Thu, 23 Mar 2023 10:32:59 +0800, Jiapeng Chong wrote:
> > > Variable 'err' set but not used.
> > >
> > > fs/buffer.c:2613:2: warning: Value stored to 'err' is never read.
> > >
> > >
> >
> > Applied to
>
> I think you should exercise extreme care with patches from "Abaci Robot".
> It's wrong more often than it's right, and the people interpreting the
> output from it do not appear to be experienced programmers.
Thank you! I've tried to be extra careful with these patches and will
continue to do so.
next prev parent reply other threads:[~2023-04-03 16:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 2:32 [PATCH v2] fs/buffer: Remove redundant assignment to err Jiapeng Chong
2023-03-27 8:10 ` Christian Brauner
2023-04-03 16:13 ` Matthew Wilcox
2023-04-03 16:41 ` Christian Brauner [this message]
2023-04-03 16:10 ` Jan Kara
2023-04-03 16:38 ` Jan Kara
2023-04-03 16:40 ` Christian Brauner
2023-04-03 16:40 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230403-battered-crusher-46d00c43a7a4@brauner \
--to=brauner@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox