From: Christian Brauner <brauner@kernel.org>
To: Jan Kara <jack@suse.cz>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH v2] fs/buffer: Remove redundant assignment to err
Date: Mon, 3 Apr 2023 18:40:40 +0200 [thread overview]
Message-ID: <20230403-mammogram-grudging-4aa3773a32af@brauner> (raw)
In-Reply-To: <20230403163802.jvwnxg4wsa3n5fpg@quack3>
On Mon, Apr 03, 2023 at 06:38:02PM +0200, Jan Kara wrote:
> On Mon 03-04-23 18:10:43, Jan Kara wrote:
> > On Thu 23-03-23 10:32:59, Jiapeng Chong wrote:
> > > Variable 'err' set but not used.
> > >
> > > fs/buffer.c:2613:2: warning: Value stored to 'err' is never read.
> > >
> > > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4589
> > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> >
> > I don't think the patch is quite correct (Christian, please drop it if I'm
> > correct). See below:
>
> Ah, sorry. I had too old kernel accidentally checked out. The patch is fine
> with current upstream. Sorry for the noise!
No problem at all. I'm very happy that you took the time to review this.
This is very much needed!
Christian
next prev parent reply other threads:[~2023-04-03 16:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 2:32 [PATCH v2] fs/buffer: Remove redundant assignment to err Jiapeng Chong
2023-03-27 8:10 ` Christian Brauner
2023-04-03 16:13 ` Matthew Wilcox
2023-04-03 16:41 ` Christian Brauner
2023-04-03 16:10 ` Jan Kara
2023-04-03 16:38 ` Jan Kara
2023-04-03 16:40 ` Christian Brauner [this message]
2023-04-03 16:40 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230403-mammogram-grudging-4aa3773a32af@brauner \
--to=brauner@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=jack@suse.cz \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox