* [PATCH] file: fix typo in take_fd() comment
@ 2024-08-09 13:50 Mathias Krause
2024-08-09 14:46 ` Christian Brauner
2024-08-09 15:21 ` Christian Brauner
0 siblings, 2 replies; 3+ messages in thread
From: Mathias Krause @ 2024-08-09 13:50 UTC (permalink / raw)
To: linux-fsdevel, Christian Brauner, Alexander Viro; +Cc: Jan Kara, Mathias Krause
The explanatory comment above take_fd() contains a typo, fix that to not
confuse readers.
Signed-off-by: Mathias Krause <minipli@grsecurity.net>
---
Btw, include/linux/file.h could get an entry in MAINTAINERS, maybe, as
could a few others matching the include/linux/fs*.h pattern?
include/linux/file.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/file.h b/include/linux/file.h
index 237931f20739..59b146a14dca 100644
--- a/include/linux/file.h
+++ b/include/linux/file.h
@@ -110,7 +110,7 @@ DEFINE_CLASS(get_unused_fd, int, if (_T >= 0) put_unused_fd(_T),
*
* f = dentry_open(&path, O_RDONLY, current_cred());
* if (IS_ERR(f))
- * return PTR_ERR(fd);
+ * return PTR_ERR(f);
*
* fd_install(fd, f);
* return take_fd(fd);
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] file: fix typo in take_fd() comment
2024-08-09 13:50 [PATCH] file: fix typo in take_fd() comment Mathias Krause
@ 2024-08-09 14:46 ` Christian Brauner
2024-08-09 15:21 ` Christian Brauner
1 sibling, 0 replies; 3+ messages in thread
From: Christian Brauner @ 2024-08-09 14:46 UTC (permalink / raw)
To: Mathias Krause; +Cc: Christian Brauner, Jan Kara, linux-fsdevel, Alexander Viro
On Fri, 09 Aug 2024 15:50:35 +0200, Mathias Krause wrote:
> The explanatory comment above take_fd() contains a typo, fix that to not
> confuse readers.
>
>
Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes
[1/1] file: fix typo in take_fd() comment
https://git.kernel.org/vfs/vfs/c/5e486881d587
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] file: fix typo in take_fd() comment
2024-08-09 13:50 [PATCH] file: fix typo in take_fd() comment Mathias Krause
2024-08-09 14:46 ` Christian Brauner
@ 2024-08-09 15:21 ` Christian Brauner
1 sibling, 0 replies; 3+ messages in thread
From: Christian Brauner @ 2024-08-09 15:21 UTC (permalink / raw)
To: Mathias Krause; +Cc: linux-fsdevel, Alexander Viro, Jan Kara
> Btw, include/linux/file.h could get an entry in MAINTAINERS, maybe, as
> could a few others matching the include/linux/fs*.h pattern?
Yeah, sure that sounds useful.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-09 15:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-09 13:50 [PATCH] file: fix typo in take_fd() comment Mathias Krause
2024-08-09 14:46 ` Christian Brauner
2024-08-09 15:21 ` Christian Brauner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox