From: Christian Brauner <brauner@kernel.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Kees Cook <kees@kernel.org>,
linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
neilb@suse.de, ebiederm@xmission.com, tony.luck@intel.com
Subject: Re: [PATCH 1/4] pstore: convert to the new mount API
Date: Thu, 6 Feb 2025 11:51:16 +0100 [thread overview]
Message-ID: <20250206-gedreht-rhythmisch-cfdc5663787d@brauner> (raw)
In-Reply-To: <57a9557f-c895-466f-afaa-a40bf818e250@redhat.com>
On Wed, Feb 05, 2025 at 08:19:06PM -0600, Eric Sandeen wrote:
> On 2/5/25 8:04 PM, Kees Cook wrote:
> >> @@ -431,19 +434,33 @@ static int pstore_fill_super(struct super_block *sb, void *data, int silent)
> >> return -ENOMEM;
> >>
> >> scoped_guard(mutex, &pstore_sb_lock)
> >> - pstore_sb = sb;
> >> + pstore_sb = sb;
> > Shouldn't scoped_guard() induce a indent?
>
> Whoops, not sure how that happened, sorry.
>
> Fix on commit or send V2?
I fixed it.
next prev parent reply other threads:[~2025-02-06 10:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 21:34 [PATCH 0/4] fs: last of the pseudofs mount api conversions Eric Sandeen
2025-02-05 21:34 ` [PATCH 1/4] pstore: convert to the new mount API Eric Sandeen
2025-02-06 2:04 ` Kees Cook
2025-02-06 2:19 ` Eric Sandeen
2025-02-06 3:30 ` Kees Cook
2025-02-06 10:51 ` Christian Brauner [this message]
2025-02-05 21:34 ` [PATCH 2/4] vfs: Convert devpts to use " Eric Sandeen
2025-02-05 21:34 ` [PATCH 3/4] devtmpfs: replace ->mount with ->get_tree in public instance Eric Sandeen
2025-02-05 21:34 ` [PATCH 4/4] vfs: remove some unused old mount api code Eric Sandeen
2025-02-06 11:04 ` [PATCH 0/4] fs: last of the pseudofs mount api conversions Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206-gedreht-rhythmisch-cfdc5663787d@brauner \
--to=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=kees@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=sandeen@redhat.com \
--cc=tony.luck@intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox