Re: [PATCH 1/4] pstore: convert to the new mount API

[Eric Sandeen <sandeen@redhat.com>]

On 2/5/25 8:04 PM, Kees Cook wrote:
>> @@ -431,19 +434,33 @@ static int pstore_fill_super(struct super_block *sb, void *data, int silent)
>> 		return -ENOMEM;
>>
>> 	scoped_guard(mutex, &pstore_sb_lock)
>> -		pstore_sb = sb;
>> +	pstore_sb = sb;
> Shouldn't scoped_guard() induce a indent?

Whoops, not sure how that happened, sorry.

Fix on commit or send V2?

>> 	pstore_get_records(0);
>>
>> 	return 0;
>> }
>>
>> -static struct dentry *pstore_mount(struct file_system_type *fs_type,
>> -	int flags, const char *dev_name, void *data)
>> +static int pstore_get_tree(struct fs_context *fc)
>> +{
>> +	if (fc->root)
>> +		return pstore_reconfigure(fc);

> I need to double check that changing kmsg_size out from under an active pstore won't cause problems, but it's probably okay. (Honestly I've been wanting to deprecate it as a mount option -- it really should just be a module param, but that's a separate task.)

Honestly I struggled with this for a while, not quite sure what's right.

> Reviewed-by: Kees Cook <kees@kernel.org>

Thanks,
-Eric

> (Is it easier to take this via fs or via pstore?)
> 
> -Kees