[PATCH] fcntl: trim arguments

[PATCH] fcntl: trim arguments

[Kanchan Joshi]

Remove superfluous argument from fcntl_{get/set}_rw_hint.
No functional change.

Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>
---
 fs/fcntl.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/fs/fcntl.c b/fs/fcntl.c
index 5598e4d57422..72f8433d9109 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -355,8 +355,7 @@ static bool rw_hint_valid(u64 hint)
 	}
 }
 
-static long fcntl_get_rw_hint(struct file *file, unsigned int cmd,
-			      unsigned long arg)
+static long fcntl_get_rw_hint(struct file *file, unsigned long arg)
 {
 	struct inode *inode = file_inode(file);
 	u64 __user *argp = (u64 __user *)arg;
@@ -367,8 +366,7 @@ static long fcntl_get_rw_hint(struct file *file, unsigned int cmd,
 	return 0;
 }
 
-static long fcntl_set_rw_hint(struct file *file, unsigned int cmd,
-			      unsigned long arg)
+static long fcntl_set_rw_hint(struct file *file, unsigned long arg)
 {
 	struct inode *inode = file_inode(file);
 	u64 __user *argp = (u64 __user *)arg;
@@ -547,10 +545,10 @@ static long do_fcntl(int fd, unsigned int cmd, unsigned long arg,
 		err = memfd_fcntl(filp, cmd, argi);
 		break;
 	case F_GET_RW_HINT:
-		err = fcntl_get_rw_hint(filp, cmd, arg);
+		err = fcntl_get_rw_hint(filp, arg);
 		break;
 	case F_SET_RW_HINT:
-		err = fcntl_set_rw_hint(filp, cmd, arg);
+		err = fcntl_set_rw_hint(filp, arg);
 		break;
 	default:
 		break;
-- 
2.25.1

Re: [PATCH] fcntl: trim arguments

[Jan Kara]

On Mon 22-09-25 17:00:46, Kanchan Joshi wrote:
> Remove superfluous argument from fcntl_{get/set}_rw_hint.
> No functional change.
> 
> Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/fcntl.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/fcntl.c b/fs/fcntl.c
> index 5598e4d57422..72f8433d9109 100644
> --- a/fs/fcntl.c
> +++ b/fs/fcntl.c
> @@ -355,8 +355,7 @@ static bool rw_hint_valid(u64 hint)
>  	}
>  }
>  
> -static long fcntl_get_rw_hint(struct file *file, unsigned int cmd,
> -			      unsigned long arg)
> +static long fcntl_get_rw_hint(struct file *file, unsigned long arg)
>  {
>  	struct inode *inode = file_inode(file);
>  	u64 __user *argp = (u64 __user *)arg;
> @@ -367,8 +366,7 @@ static long fcntl_get_rw_hint(struct file *file, unsigned int cmd,
>  	return 0;
>  }
>  
> -static long fcntl_set_rw_hint(struct file *file, unsigned int cmd,
> -			      unsigned long arg)
> +static long fcntl_set_rw_hint(struct file *file, unsigned long arg)
>  {
>  	struct inode *inode = file_inode(file);
>  	u64 __user *argp = (u64 __user *)arg;
> @@ -547,10 +545,10 @@ static long do_fcntl(int fd, unsigned int cmd, unsigned long arg,
>  		err = memfd_fcntl(filp, cmd, argi);
>  		break;
>  	case F_GET_RW_HINT:
> -		err = fcntl_get_rw_hint(filp, cmd, arg);
> +		err = fcntl_get_rw_hint(filp, arg);
>  		break;
>  	case F_SET_RW_HINT:
> -		err = fcntl_set_rw_hint(filp, cmd, arg);
> +		err = fcntl_set_rw_hint(filp, arg);
>  		break;
>  	default:
>  		break;
> -- 
> 2.25.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: [PATCH] fcntl: trim arguments

[Christian Brauner]

On Mon, 22 Sep 2025 17:00:46 +0530, Kanchan Joshi wrote:
> Remove superfluous argument from fcntl_{get/set}_rw_hint.
> No functional change.
> 
> 

Applied to the vfs-6.18.misc branch of the vfs/vfs.git tree.
Patches in the vfs-6.18.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.18.misc

[1/1] fcntl: trim arguments
      https://git.kernel.org/vfs/vfs/c/e6524dd4c068