Linux filesystem development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>
Cc: Jan Kara <jack@suse.cz>, David Sterba <dsterba@suse.com>,
	Luis de Bethencourt <luisbg@kernel.org>,
	Salah Triki <salah.triki@gmail.com>,
	"Tigran A. Aivazian" <aivazian.tigran@gmail.com>,
	Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
	Dave Kleikamp <shaggy@kernel.org>,
	Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	Bob Copeland <me@bobcopeland.com>, Anders Larsen <al@alarsen.net>,
	linux-fsdevel@vger.kernel.org,
	jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev,
	linux-karma-devel@lists.sourceforge.net
Subject: [PATCH 09/10] ntfs3: handle set_blocksize failures
Date: Mon, 11 May 2026 09:16:54 +0200	[thread overview]
Message-ID: <20260511071701.2456211-10-hch@lst.de> (raw)
In-Reply-To: <20260511071701.2456211-1-hch@lst.de>

ntfs3 uses buffer_heads, which don't handle block size > PAGE_SIZE well.
Without this, mounting we will hit the

        BUG_ON(offset >= folio_size(folio));

in folio_set_bh on the first __bread_gfp call.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/ntfs3/super.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 004f59937559..3305fe406cb2 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -1174,7 +1174,10 @@ static int ntfs_init_from_boot(struct super_block *sb, u32 sector_size,
 	rec->total = cpu_to_le32(sbi->record_size);
 	((struct ATTRIB *)Add2Ptr(rec, ao))->type = ATTR_END;
 
-	sb_set_blocksize(sb, min_t(u32, sbi->cluster_size, PAGE_SIZE));
+	if (!sb_set_blocksize(sb, min_t(u32, sbi->cluster_size, PAGE_SIZE))) {
+		err = -EINVAL;
+		goto out;
+	}
 
 	sbi->block_mask = sb->s_blocksize - 1;
 	sbi->blocks_per_cluster = sbi->cluster_size >> sb->s_blocksize_bits;
@@ -1225,7 +1228,8 @@ static int ntfs_init_from_boot(struct super_block *sb, u32 sector_size,
 			/*
 			 * Try alternative boot (last sector)
 			 */
-			sb_set_blocksize(sb, block_size);
+			if (!sb_set_blocksize(sb, block_size))
+				return -EINVAL;
 			hint = "Alternative boot";
 			dev_size = dev_size0; /* restore original size. */
 			goto read_boot;
-- 
2.53.0


  parent reply	other threads:[~2026-05-11  7:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11  7:16 fix crashes when mounting legacy file system with sector size > PAGE_SIZE Christoph Hellwig
2026-05-11  7:16 ` [PATCH 01/10] bfs: handle set_blocksize failures Christoph Hellwig
2026-05-11 16:10   ` Jan Kara
2026-05-11  7:16 ` [PATCH 02/10] hpfs: " Christoph Hellwig
2026-05-11  7:16 ` [PATCH 03/10] qnx4: " Christoph Hellwig
2026-05-11  7:42   ` Anders Larsen
2026-05-11  7:45     ` Christoph Hellwig
2026-05-11  8:20       ` Anders Larsen
2026-05-11  7:16 ` [PATCH 04/10] jfs: " Christoph Hellwig
2026-05-11  7:16 ` [PATCH 05/10] befs: " Christoph Hellwig
2026-05-11  7:16 ` [PATCH 06/10] affs: " Christoph Hellwig
2026-05-11  7:16 ` [PATCH 07/10] isofs: " Christoph Hellwig
2026-05-11 16:10   ` Jan Kara
2026-05-11  7:16 ` [PATCH 08/10] minix: " Christoph Hellwig
2026-05-11 16:08   ` Jan Kara
2026-05-12  6:08     ` Christoph Hellwig
2026-05-12 12:13       ` Christian Brauner
2026-05-11  7:16 ` Christoph Hellwig [this message]
2026-05-11  7:16 ` [PATCH 10/10] omfs: " Christoph Hellwig
2026-05-11 13:40   ` Christian Brauner
2026-05-11 13:41 ` fix crashes when mounting legacy file system with sector size > PAGE_SIZE Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260511071701.2456211-10-hch@lst.de \
    --to=hch@lst.de \
    --cc=aivazian.tigran@gmail.com \
    --cc=al@alarsen.net \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=brauner@kernel.org \
    --cc=dsterba@suse.com \
    --cc=jack@suse.cz \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-karma-devel@lists.sourceforge.net \
    --cc=luisbg@kernel.org \
    --cc=me@bobcopeland.com \
    --cc=mikulas@artax.karlin.mff.cuni.cz \
    --cc=ntfs3@lists.linux.dev \
    --cc=salah.triki@gmail.com \
    --cc=shaggy@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox