Linux filesystem development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>
Cc: Jan Kara <jack@suse.cz>, David Sterba <dsterba@suse.com>,
	Luis de Bethencourt <luisbg@kernel.org>,
	Salah Triki <salah.triki@gmail.com>,
	"Tigran A. Aivazian" <aivazian.tigran@gmail.com>,
	Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
	Dave Kleikamp <shaggy@kernel.org>,
	Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	Bob Copeland <me@bobcopeland.com>, Anders Larsen <al@alarsen.net>,
	linux-fsdevel@vger.kernel.org,
	jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev,
	linux-karma-devel@lists.sourceforge.net
Subject: [PATCH 10/10] omfs: handle set_blocksize failures
Date: Mon, 11 May 2026 09:16:55 +0200	[thread overview]
Message-ID: <20260511071701.2456211-11-hch@lst.de> (raw)
In-Reply-To: <20260511071701.2456211-1-hch@lst.de>

omfs uses buffer_heads, which don't handle block size > PAGE_SIZE well.
Without this, mounting we will hit the

        BUG_ON(offset >= folio_size(folio));

in folio_set_bh on the first __bread_gfp call.

Signed-off-by: Christoph Hellwig <hch@lst.de>

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/omfs/inode.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c
index 834cae1e6223..1d915ef72119 100644
--- a/fs/omfs/inode.c
+++ b/fs/omfs/inode.c
@@ -478,7 +478,8 @@ static int omfs_fill_super(struct super_block *sb, struct fs_context *fc)
 	sb->s_time_min = 0;
 	sb->s_time_max = U64_MAX / MSEC_PER_SEC;
 
-	sb_set_blocksize(sb, 0x200);
+	if (!sb_set_blocksize(sb, 0x200))
+		goto end;
 
 	bh = sb_bread(sb, 0);
 	if (!bh)
@@ -530,7 +531,8 @@ static int omfs_fill_super(struct super_block *sb, struct fs_context *fc)
 	 * Use sys_blocksize as the fs block since it is smaller than a
 	 * page while the fs blocksize can be larger.
 	 */
-	sb_set_blocksize(sb, sbi->s_sys_blocksize);
+	if (!sb_set_blocksize(sb, sbi->s_sys_blocksize))
+		goto out_brelse_bh;
 
 	/*
 	 * ...and the difference goes into a shift.  sys_blocksize is always
-- 
2.53.0


  parent reply	other threads:[~2026-05-11  7:18 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11  7:16 fix crashes when mounting legacy file system with sector size > PAGE_SIZE Christoph Hellwig
2026-05-11  7:16 ` [PATCH 01/10] bfs: handle set_blocksize failures Christoph Hellwig
2026-05-11 16:10   ` Jan Kara
2026-05-11  7:16 ` [PATCH 02/10] hpfs: " Christoph Hellwig
2026-05-11  7:16 ` [PATCH 03/10] qnx4: " Christoph Hellwig
2026-05-11  7:42   ` Anders Larsen
2026-05-11  7:45     ` Christoph Hellwig
2026-05-11  8:20       ` Anders Larsen
2026-05-11  7:16 ` [PATCH 04/10] jfs: " Christoph Hellwig
2026-05-11  7:16 ` [PATCH 05/10] befs: " Christoph Hellwig
2026-05-11  7:16 ` [PATCH 06/10] affs: " Christoph Hellwig
2026-05-11  7:16 ` [PATCH 07/10] isofs: " Christoph Hellwig
2026-05-11 16:10   ` Jan Kara
2026-05-11  7:16 ` [PATCH 08/10] minix: " Christoph Hellwig
2026-05-11 16:08   ` Jan Kara
2026-05-12  6:08     ` Christoph Hellwig
2026-05-12 12:13       ` Christian Brauner
2026-05-11  7:16 ` [PATCH 09/10] ntfs3: " Christoph Hellwig
2026-05-11  7:16 ` Christoph Hellwig [this message]
2026-05-11 13:40   ` [PATCH 10/10] omfs: " Christian Brauner
2026-05-11 13:41 ` fix crashes when mounting legacy file system with sector size > PAGE_SIZE Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260511071701.2456211-11-hch@lst.de \
    --to=hch@lst.de \
    --cc=aivazian.tigran@gmail.com \
    --cc=al@alarsen.net \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=brauner@kernel.org \
    --cc=dsterba@suse.com \
    --cc=jack@suse.cz \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-karma-devel@lists.sourceforge.net \
    --cc=luisbg@kernel.org \
    --cc=me@bobcopeland.com \
    --cc=mikulas@artax.karlin.mff.cuni.cz \
    --cc=ntfs3@lists.linux.dev \
    --cc=salah.triki@gmail.com \
    --cc=shaggy@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox