Linux filesystem development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Viacheslav Dubeyko <slava@dubeyko.com>
Cc: Christoph Hellwig <hch@lst.de>,
	glaubitz@physik.fu-berlin.de, frank.li@vivo.com,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/6] hfsplus: take the bitmap page lock for allocate/free
Date: Tue, 28 Jul 2026 05:58:18 +0200	[thread overview]
Message-ID: <20260728035818.GA19357@lst.de> (raw)
In-Reply-To: <f532f95937e8a5123ac07a796bc5aff40c2ffa40.camel@dubeyko.com>

On Fri, Jul 24, 2026 at 12:40:36PM -0700, Viacheslav Dubeyko wrote:
> > You are still unprotected against concurrent writeback, as writeback
> > drops the page lock before writing the data out.
> 
> 
> Yeah, you are right. As far as I can see, the sbi->alloc_mutex is the
> main mechanism of synchronization of access to Allocation File (block
> bitmap). And I see that hfsplus_sync_fs() doesn't use it during
> filemap_write_and_wait(sbi->alloc_file->i_mapping). Probably, it should
> be used there. Let me double check it. What do you think?

I don't really know what scheme hfsplus uses for synchronization here,
set mapping_set_stable_writes on the btree inode mapping and use
folio_wait_stable after locking the folio.


  reply	other threads:[~2026-07-28  3:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22 21:37 [PATCH 0/6] hfsplus: convert regular file I/O to iomap-based operations Viacheslav Dubeyko
2026-07-22 21:37 ` [PATCH 1/6] hfs/hfsplus: exchange hardcoded number of extents on named constants Viacheslav Dubeyko
2026-07-24  5:28   ` Christoph Hellwig
2026-07-22 21:37 ` [PATCH 2/6] hfsplus: rework hfsplus_get_block() logic Viacheslav Dubeyko
2026-07-24  5:28   ` Christoph Hellwig
2026-07-22 21:37 ` [PATCH 3/6] hfsplus: take the bitmap page lock for allocate/free Viacheslav Dubeyko
2026-07-24  5:29   ` Christoph Hellwig
2026-07-24 19:40     ` Viacheslav Dubeyko
2026-07-28  3:58       ` Christoph Hellwig [this message]
2026-07-22 21:37 ` [PATCH 4/6] hfsplus: add iomap operations for regular file data Viacheslav Dubeyko
2026-07-24  5:32   ` Christoph Hellwig
2026-07-24 19:45     ` Viacheslav Dubeyko
2026-07-28  3:58       ` Christoph Hellwig
2026-07-22 21:37 ` [PATCH 5/6] hfsplus: add iomap-based file_operations Viacheslav Dubeyko
2026-07-24  5:33   ` Christoph Hellwig
2026-07-24 19:46     ` Viacheslav Dubeyko
2026-07-22 21:37 ` [PATCH 6/6] hfsplus: switch address_space_operations on iomap-based support Viacheslav Dubeyko
2026-07-24  5:37   ` Christoph Hellwig
2026-07-24 19:50     ` Viacheslav Dubeyko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260728035818.GA19357@lst.de \
    --to=hch@lst.de \
    --cc=frank.li@vivo.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=slava@dubeyko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox