From: Christoph Hellwig <hch@lst.de>
To: Viacheslav Dubeyko <slava@dubeyko.com>
Cc: Christoph Hellwig <hch@lst.de>,
glaubitz@physik.fu-berlin.de, frank.li@vivo.com,
linux-fsdevel@vger.kernel.org,
Namjae Jeon <linkinjeon@kernel.org>
Subject: Re: [PATCH 4/6] hfsplus: add iomap operations for regular file data
Date: Tue, 28 Jul 2026 05:58:55 +0200 [thread overview]
Message-ID: <20260728035855.GB19357@lst.de> (raw)
In-Reply-To: <78cb029e014d9590463729c43519b647f3a38dd3.camel@dubeyko.com>
On Fri, Jul 24, 2026 at 12:45:14PM -0700, Viacheslav Dubeyko wrote:
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * linux/fs/hfsplus/iomap.c
> >
> > Please don't put the file name into the file itself. It is pointless
> > and prone to get out of date.
>
> I am simply following the driver context. Other HFS+ files contain
> this. I can remove it, of course, if you like.
Yes, don't add it to new files, and remove it from existing ones if
you have to touch them anyway.
next prev parent reply other threads:[~2026-07-28 3:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 21:37 [PATCH 0/6] hfsplus: convert regular file I/O to iomap-based operations Viacheslav Dubeyko
2026-07-22 21:37 ` [PATCH 1/6] hfs/hfsplus: exchange hardcoded number of extents on named constants Viacheslav Dubeyko
2026-07-24 5:28 ` Christoph Hellwig
2026-07-22 21:37 ` [PATCH 2/6] hfsplus: rework hfsplus_get_block() logic Viacheslav Dubeyko
2026-07-24 5:28 ` Christoph Hellwig
2026-07-22 21:37 ` [PATCH 3/6] hfsplus: take the bitmap page lock for allocate/free Viacheslav Dubeyko
2026-07-24 5:29 ` Christoph Hellwig
2026-07-24 19:40 ` Viacheslav Dubeyko
2026-07-28 3:58 ` Christoph Hellwig
2026-07-22 21:37 ` [PATCH 4/6] hfsplus: add iomap operations for regular file data Viacheslav Dubeyko
2026-07-24 5:32 ` Christoph Hellwig
2026-07-24 19:45 ` Viacheslav Dubeyko
2026-07-28 3:58 ` Christoph Hellwig [this message]
2026-07-22 21:37 ` [PATCH 5/6] hfsplus: add iomap-based file_operations Viacheslav Dubeyko
2026-07-24 5:33 ` Christoph Hellwig
2026-07-24 19:46 ` Viacheslav Dubeyko
2026-07-22 21:37 ` [PATCH 6/6] hfsplus: switch address_space_operations on iomap-based support Viacheslav Dubeyko
2026-07-24 5:37 ` Christoph Hellwig
2026-07-24 19:50 ` Viacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728035855.GB19357@lst.de \
--to=hch@lst.de \
--cc=frank.li@vivo.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=slava@dubeyko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox