Linux filesystem development
 help / color / mirror / Atom feed
* [PATCH v2] selftests/proc: make proc-maps-race work with READ_IMPLIES_EXEC
@ 2026-08-08 20:03 Karl Mehltretter
  0 siblings, 0 replies; only message in thread
From: Karl Mehltretter @ 2026-08-08 20:03 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Karl Mehltretter, Suren Baghdasaryan, Liam R. Howlett,
	Lorenzo Stoakes, David Hildenbrand, Vlastimil Babka, Jann Horn,
	Alexey Dobriyan, Shuah Khan, linux-mm, linux-fsdevel,
	linux-kselftest, linux-kernel

test_maps_tearing_from_split times out when READ_IMPLIES_EXEC is set.
This happens by default on pre-ARMv6 CPUs, which lack no-execute support.

split_vma() re-maps the first page with mod_info->prot | PROT_EXEC to
make it differ from its neighbours.  With READ_IMPLIES_EXEC the original
mapping is already executable, so no split occurs and the test hangs
waiting for the modifier child.

Use PROT_NONE for the split mapping, which always differs from its
readable neighbours.

Fixes: beb69e817246 ("selftests/proc: add /proc/pid/maps tearing from vma split test")
Assisted-by: Codex:gpt-5.6-terra
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
Tested on:
- QEMU versatilepb/ARM926EJ-S: maps and smaps fail before, pass after
- QEMU realview-eb-mpcore/ARM11MPCore: maps and smaps pass before and after

Changes since v1:
- v1 went out without any recipients in To: and received no reply in 19 days.
- No functional change. reworked the commit message.

v1: https://lore.kernel.org/all/20260720061835.6290-1-kmehltretter@gmail.com/

 tools/testing/selftests/proc/proc-maps-race.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/proc/proc-maps-race.c b/tools/testing/selftests/proc/proc-maps-race.c
index 1026d8c400e1..415eccb70468 100644
--- a/tools/testing/selftests/proc/proc-maps-race.c
+++ b/tools/testing/selftests/proc/proc-maps-race.c
@@ -490,7 +490,8 @@ static bool query_addr_at(int maps_fd, void *addr,
 
 static inline bool split_vma(FIXTURE_DATA(proc_maps_race) *self)
 {
-	return mmap(self->mod_info->addr, self->page_size, self->mod_info->prot | PROT_EXEC,
+	/* PROT_NONE differs from both readable neighbors. */
+	return mmap(self->mod_info->addr, self->page_size, PROT_NONE,
 		    MAP_PRIVATE | MAP_ANONYMOUS | MAP_FIXED, -1, 0) != MAP_FAILED;
 }
 
-- 
2.53.0

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-08-08 20:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-08 20:03 [PATCH v2] selftests/proc: make proc-maps-race work with READ_IMPLIES_EXEC Karl Mehltretter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox