Linux filesystem development
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: NeilBrown <neil@brown.name>, Oleg Nesterov <oleg@redhat.com>,
	 linux-fsdevel@vger.kernel.org
Cc: Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
	 Xin Zhao <jackzxcui1989@163.com>,
	Mateusz Guzik <mjguzik@gmail.com>,
	 Jeff Layton <jlayton@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	 "Christian Brauner (Amutable)" <brauner@kernel.org>
Subject: [PATCH RFC v2 12/16] coredump: factor out coredump_wait_inactive()
Date: Wed, 02 Sep 2026 17:58:30 +0200	[thread overview]
Message-ID: <20260902-work-coredump-unlock-self-v2-12-1bece368cbb1@kernel.org> (raw)
In-Reply-To: <20260902-work-coredump-unlock-self-v2-0-1bece368cbb1@kernel.org>

Factor out a new  coredump_wait_inactive() helper that
COREDUMP_CLOSE_FILES can consume in a bit.

No functional changes.

Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
---
 fs/coredump.c | 36 ++++++++++++++++++++----------------
 1 file changed, 20 insertions(+), 16 deletions(-)

diff --git a/fs/coredump.c b/fs/coredump.c
index 545a6df48ea8..d0796536e03f 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -518,6 +518,24 @@ static int zap_threads(struct task_struct *tsk,
 	return nr;
 }
 
+static void coredump_wait_inactive(struct core_state *core_state)
+{
+	struct core_thread *ptr;
+
+	wait_for_completion_state(&core_state->done,
+				  TASK_UNINTERRUPTIBLE|TASK_FREEZABLE);
+	/*
+	 * Wait for all the threads to become inactive, so that
+	 * all the thread context (extended register state, like
+	 * fpu etc) gets copied to the memory.
+	 */
+	ptr = core_state->dumper.next;
+	while (ptr != NULL) {
+		wait_task_inactive(ptr->task, TASK_ANY);
+		ptr = ptr->next;
+	}
+}
+
 static int coredump_wait(int exit_code, struct core_state *core_state)
 {
 	struct task_struct *tsk = current;
@@ -528,22 +546,8 @@ static int coredump_wait(int exit_code, struct core_state *core_state)
 	core_state->dumper.next = NULL;
 
 	core_waiters = zap_threads(tsk, core_state, exit_code);
-	if (core_waiters > 0) {
-		struct core_thread *ptr;
-
-		wait_for_completion_state(&core_state->done,
-					  TASK_UNINTERRUPTIBLE|TASK_FREEZABLE);
-		/*
-		 * Wait for all the threads to become inactive, so that
-		 * all the thread context (extended register state, like
-		 * fpu etc) gets copied to the memory.
-		 */
-		ptr = core_state->dumper.next;
-		while (ptr != NULL) {
-			wait_task_inactive(ptr->task, TASK_ANY);
-			ptr = ptr->next;
-		}
-	}
+	if (core_waiters > 0)
+		coredump_wait_inactive(core_state);
 
 	return core_waiters;
 }

-- 
2.53.0


  parent reply	other threads:[~2026-09-02 15:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 15:58 [PATCH RFC v2 00/16] coredump, files: exit files on request Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 01/16] fs: don't open-code file_close_fd() in close_fd() Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 02/16] fs: add fput_close_list() and fput_list() Christian Brauner
2026-09-02 17:41   ` Mateusz Guzik
2026-09-02 17:58     ` Mateusz Guzik
2026-09-04  8:22       ` Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 03/16] fs: rename do_close_on_exec() to close_cloexec_files() Christian Brauner
2026-09-02 17:41   ` Mateusz Guzik
2026-09-02 15:58 ` [PATCH RFC v2 04/16] fs: defer the final fput of close-on-exec files past the exec locks Christian Brauner
2026-09-02 17:50   ` Mateusz Guzik
2026-09-02 15:58 ` [PATCH RFC v2 05/16] fs: add switch_files_struct() Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 06/16] fs: move unshare_fd() to fs/file.c Christian Brauner
2026-09-02 17:51   ` Mateusz Guzik
2026-09-02 15:58 ` [PATCH RFC v2 07/16] fs: remove unshare_files() Christian Brauner
2026-09-02 17:52   ` Mateusz Guzik
2026-09-02 15:58 ` [PATCH RFC v2 08/16] exec: release fdtable after exec locks drop Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 09/16] fs: make close_files() synchronous Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 10/16] fs: make close_range() synchronous Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 11/16] coredump: s/startup/done/g Christian Brauner
2026-09-02 15:58 ` Christian Brauner [this message]
2026-09-02 15:58 ` [PATCH RFC v2 13/16] fs: add alloc_files_struct() Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 14/16] coredump: add COREDUMP_CLOSE_FILES Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 15/16] tools: sync coredump.h header Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 16/16] selftests/coredump: test COREDUMP_CLOSE_FILES Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260902-work-coredump-unlock-self-v2-12-1bece368cbb1@kernel.org \
    --to=brauner@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=jack@suse.cz \
    --cc=jackzxcui1989@163.com \
    --cc=jlayton@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mjguzik@gmail.com \
    --cc=neil@brown.name \
    --cc=oleg@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox