From: Christian Brauner <brauner@kernel.org>
To: NeilBrown <neil@brown.name>, Oleg Nesterov <oleg@redhat.com>,
linux-fsdevel@vger.kernel.org
Cc: Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Xin Zhao <jackzxcui1989@163.com>,
Mateusz Guzik <mjguzik@gmail.com>,
Jeff Layton <jlayton@kernel.org>, Jens Axboe <axboe@kernel.dk>,
"Christian Brauner (Amutable)" <brauner@kernel.org>
Subject: [PATCH RFC v2 03/16] fs: rename do_close_on_exec() to close_cloexec_files()
Date: Wed, 02 Sep 2026 17:58:21 +0200 [thread overview]
Message-ID: <20260902-work-coredump-unlock-self-v2-3-1bece368cbb1@kernel.org> (raw)
In-Reply-To: <20260902-work-coredump-unlock-self-v2-0-1bece368cbb1@kernel.org>
Rename the helper and align it with close_files().
No functional changes.
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
---
fs/exec.c | 2 +-
fs/file.c | 2 +-
include/linux/fdtable.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/exec.c b/fs/exec.c
index 745f6eb5279e..92a02bce11d5 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1220,7 +1220,7 @@ int begin_new_exec(struct linux_binprm * bprm)
* trying to access the should-be-closed file descriptors of a process
* undergoing exec(2).
*/
- do_close_on_exec(me->files);
+ close_cloexec_files(me->files);
if (bprm->secureexec) {
/* Make sure parent cannot signal privileged process. */
diff --git a/fs/file.c b/fs/file.c
index 59673547de90..be06e09df41c 100644
--- a/fs/file.c
+++ b/fs/file.c
@@ -884,7 +884,7 @@ struct file *file_close_fd(unsigned int fd)
return file;
}
-void do_close_on_exec(struct files_struct *files)
+void close_cloexec_files(struct files_struct *files)
{
unsigned i;
struct fdtable *fdt;
diff --git a/include/linux/fdtable.h b/include/linux/fdtable.h
index c45306a9f007..e6b641d9eb91 100644
--- a/include/linux/fdtable.h
+++ b/include/linux/fdtable.h
@@ -105,7 +105,7 @@ struct fd_range {
unsigned int from, to;
};
struct files_struct *dup_fd(struct files_struct *, struct fd_range *) __latent_entropy;
-void do_close_on_exec(struct files_struct *);
+void close_cloexec_files(struct files_struct *);
int iterate_fd(struct files_struct *, unsigned,
int (*)(const void *, struct file *, unsigned),
const void *);
--
2.53.0
next prev parent reply other threads:[~2026-09-02 15:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 15:58 [PATCH RFC v2 00/16] coredump, files: exit files on request Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 01/16] fs: don't open-code file_close_fd() in close_fd() Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 02/16] fs: add fput_close_list() and fput_list() Christian Brauner
2026-09-02 17:41 ` Mateusz Guzik
2026-09-02 17:58 ` Mateusz Guzik
2026-09-04 8:22 ` Christian Brauner
2026-09-02 15:58 ` Christian Brauner [this message]
2026-09-02 17:41 ` [PATCH RFC v2 03/16] fs: rename do_close_on_exec() to close_cloexec_files() Mateusz Guzik
2026-09-02 15:58 ` [PATCH RFC v2 04/16] fs: defer the final fput of close-on-exec files past the exec locks Christian Brauner
2026-09-02 17:50 ` Mateusz Guzik
2026-09-02 15:58 ` [PATCH RFC v2 05/16] fs: add switch_files_struct() Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 06/16] fs: move unshare_fd() to fs/file.c Christian Brauner
2026-09-02 17:51 ` Mateusz Guzik
2026-09-02 15:58 ` [PATCH RFC v2 07/16] fs: remove unshare_files() Christian Brauner
2026-09-02 17:52 ` Mateusz Guzik
2026-09-02 15:58 ` [PATCH RFC v2 08/16] exec: release fdtable after exec locks drop Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 09/16] fs: make close_files() synchronous Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 10/16] fs: make close_range() synchronous Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 11/16] coredump: s/startup/done/g Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 12/16] coredump: factor out coredump_wait_inactive() Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 13/16] fs: add alloc_files_struct() Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 14/16] coredump: add COREDUMP_CLOSE_FILES Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 15/16] tools: sync coredump.h header Christian Brauner
2026-09-02 15:58 ` [PATCH RFC v2 16/16] selftests/coredump: test COREDUMP_CLOSE_FILES Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902-work-coredump-unlock-self-v2-3-1bece368cbb1@kernel.org \
--to=brauner@kernel.org \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=jackzxcui1989@163.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=neil@brown.name \
--cc=oleg@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox