Linux filesystem development
 help / color / mirror / Atom feed
From: Matthias Goergens <matthias.goergens@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: Hui Peng <benquike@gmail.com>,
	Christian Brauner <brauner@kernel.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] isofs: bound empty directory blocks in isofs_read_level3_size()
Date: Wed, 30 Sep 2026 11:39:40 +0800	[thread overview]
Message-ID: <20260930033940.175021-1-matthias.goergens@gmail.com> (raw)
In-Reply-To: <cm3n7vjwbdnafttuz5ftkzz5wdbalgews4dfs5zlwvkyuzotuq@jo2nhsplhstc>

Hi Honza,

> Any reason why don't you do just "++i > 100" here and completely
> remove the empty_blocks variable?

Yes: i has one other use.  The "if (i == 1)" further down records
where the second section starts (i_next_section_block/offset).
Counting empty blocks in i would move i past 1 before the second
record is read when an empty block sits between the first two
records, so the next-section link stays 0 and isofs_get_blocks()
reads past the first extent into whatever follows it on disk.  I
tried your variant on a two-section image with one empty block
between the records: v1 reads the file correctly, the variant returns
different bytes.

I'm happy to send a v2 that adds a comment saying why the count stays
out of i, if you'd like one.

Thanks,
Matthias

  reply	other threads:[~2026-09-30  3:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-19 22:25 [PATCH] isofs: reject short directory records in isofs_read_level3_size() Hui Peng
2026-09-23 17:52 ` Matthias Goergens
2026-09-24 15:03   ` Jan Kara
2026-09-24 15:13     ` Matthias Goergens
2026-09-25  4:38       ` Matthias Goergens
2026-09-25  9:28         ` Jan Kara
2026-09-25 11:22           ` Matthias Goergens
2026-09-26  8:35           ` [PATCH] isofs: bound empty directory blocks " Matthias Goergens
2026-09-29 10:57             ` Jan Kara
2026-09-30  3:39               ` Matthias Goergens [this message]
2026-09-30 10:33                 ` Jan Kara
2026-10-01 10:30                   ` Matthias Goergens
2026-10-02 10:55                     ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260930033940.175021-1-matthias.goergens@gmail.com \
    --to=matthias.goergens@gmail.com \
    --cc=benquike@gmail.com \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox