From: Matthias Goergens <matthias.goergens@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: Hui Peng <benquike@gmail.com>,
Christian Brauner <brauner@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] isofs: bound empty directory blocks in isofs_read_level3_size()
Date: Thu, 1 Oct 2026 18:30:00 +0800 [thread overview]
Message-ID: <20261001103000.3408032-1-matthias.goergens@gmail.com> (raw)
In-Reply-To: <xr6nxaat4f4zlmnk6dcn6fyiih336io2qaxm6lytxyb23oznw6@xcd4rjwpg4di>
Hi Honza,
> Right, that needs a bit more care but still, something like the attached
> patch should work?
Yes, it does. Testing the next-section link as "not yet set" instead
of "i == 1" is what was missing from the first variant. I ran your
patch on top of v1, built in userspace with ASan and UBSan, against 67
test images: empty blocks between and after the section records,
three-section files, and the 100 bound from both sides. i_size, the
recorded next section, the limit message and the file contents match
v1 on every image, including the split-gap one your first variant read
wrongly. No sanitizer reports.
Reviewed-by: Matthias Goergens <matthias.goergens@gmail.com>
Tested-by: Matthias Goergens <matthias.goergens@gmail.com>
Thanks,
Matthias
next prev parent reply other threads:[~2026-10-01 10:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 22:25 [PATCH] isofs: reject short directory records in isofs_read_level3_size() Hui Peng
2026-09-23 17:52 ` Matthias Goergens
2026-09-24 15:03 ` Jan Kara
2026-09-24 15:13 ` Matthias Goergens
2026-09-25 4:38 ` Matthias Goergens
2026-09-25 9:28 ` Jan Kara
2026-09-25 11:22 ` Matthias Goergens
2026-09-26 8:35 ` [PATCH] isofs: bound empty directory blocks " Matthias Goergens
2026-09-29 10:57 ` Jan Kara
2026-09-30 3:39 ` Matthias Goergens
2026-09-30 10:33 ` Jan Kara
2026-10-01 10:30 ` Matthias Goergens [this message]
2026-10-02 10:55 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001103000.3408032-1-matthias.goergens@gmail.com \
--to=matthias.goergens@gmail.com \
--cc=benquike@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox