From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] block: loop: mark bvec as ITER_BVEC_FLAG_NO_REF
Date: Thu, 28 Mar 2019 08:18:02 -0600 [thread overview]
Message-ID: <2ac9386c-4a4f-3d39-e0be-b597fa63d0f0@kernel.dk> (raw)
In-Reply-To: <20190328030531.28279-1-ming.lei@redhat.com>
On 3/27/19 9:05 PM, Ming Lei wrote:
> loop is one block device, for any bio submitted to this device,
> the upper layer does guarantee that pages added to loop's bio won't
> go away when the bio is in-flight.
>
> So mark loop's bvec as ITER_BVEC_FLAG_NO_REF then get_page/put_page
> can be saved for serving loop's IO.
Curious if this is a noticable win on loop? In any case, looks
fine to me, I'll queue it up for 5.2.
--
Jens Axboe
next prev parent reply other threads:[~2019-03-28 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 3:05 [PATCH] block: loop: mark bvec as ITER_BVEC_FLAG_NO_REF Ming Lei
2019-03-28 14:18 ` Jens Axboe [this message]
2019-03-28 15:02 ` Christoph Hellwig
2019-03-28 15:07 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ac9386c-4a4f-3d39-e0be-b597fa63d0f0@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox