From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>, Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] block: loop: mark bvec as ITER_BVEC_FLAG_NO_REF
Date: Thu, 28 Mar 2019 09:07:18 -0600 [thread overview]
Message-ID: <f14d6b1e-2853-cc79-363a-34b5a0596930@kernel.dk> (raw)
In-Reply-To: <20190328150224.GA9265@infradead.org>
On 3/28/19 9:02 AM, Christoph Hellwig wrote:
>> + iov_iter_bvec(i, direction, bvec, nr_segs, count);
>> + i->type |= ITER_BVEC_FLAG_NO_REF;
>> +}
>
> What about simply providing a iov_iter_bvec_noref in core code and
> also using that in io_uring?
>
> Otherwise this looks fine to me.
I'd be fine with that helper.
--
Jens Axboe
prev parent reply other threads:[~2019-03-28 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 3:05 [PATCH] block: loop: mark bvec as ITER_BVEC_FLAG_NO_REF Ming Lei
2019-03-28 14:18 ` Jens Axboe
2019-03-28 15:02 ` Christoph Hellwig
2019-03-28 15:07 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f14d6b1e-2853-cc79-363a-34b5a0596930@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox