Linux filesystem development
 help / color / mirror / Atom feed
From: Daniel Phillips <phillips@google.com>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: christoph <hch@lst.de>,
	akpm@osdl.org, mcao@us.ibm.com,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] map multiple blocks at a time in mpage_readpages()
Date: Tue, 14 Feb 2006 15:30:22 -0800	[thread overview]
Message-ID: <43F2680E.7060306@google.com> (raw)
In-Reply-To: <1139939347.4762.18.camel@dyn9047017100.beaverton.ibm.com>

Badari Pulavarty wrote:
> +		for (i = 0; ; i++) {
> +			if (i == nblocks) {
> +				*map_valid = 0;
> +				break;
> +			} else if (page_block == blocks_per_page)
> +				break;
> +			blocks[page_block] = map_bh->b_blocknr + i;
> +			page_block++;
> +			block_in_file++;
> +		}

Hi Badari, a tiny nit:

		for (i = 0; ; i++) {
			if (i == nblocks) {
				*map_valid = 0;
				break;
			}
			if (page_block == blocks_per_page)
				break;
			blocks[page_block] = map_bh->b_blocknr + i;
			page_block++;
			block_in_file++;
		}

Regards,

Daniel

  parent reply	other threads:[~2006-02-14 23:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-14 17:49 [RFC][PATCH] map multiple blocks at a time in mpage_readpages() Badari Pulavarty
2006-02-14 19:27 ` christoph
2006-02-14 21:53   ` Badari Pulavarty
2006-02-14 22:53   ` Badari Pulavarty
2006-02-14 23:30 ` Daniel Phillips [this message]
2006-02-14 23:49   ` Badari Pulavarty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43F2680E.7060306@google.com \
    --to=phillips@google.com \
    --cc=akpm@osdl.org \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcao@us.ibm.com \
    --cc=pbadari@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox