From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-fsdevel@vger.kernel.org,
"Christian Brauner" <brauner@kernel.org>,
"Christoph Hellwig" <hch@infradead.org>,
"Bill O'Donnell" <billodo@redhat.com>,
"Krzysztof Błaszkowski" <kb@sysmikro.com.pl>
Subject: Re: [PATCH] freevxfs: Convert freevxfs to the new mount API.
Date: Tue, 5 Mar 2024 05:47:52 -0800 [thread overview]
Message-ID: <ZeciiH1jYeT3juD7@infradead.org> (raw)
In-Reply-To: <b0d1a423-4b8e-4bc1-a021-a1078aee915f@redhat.com>
> +static int vxfs_init_fs_context(struct fs_context *fc)
> +{
> + fc->ops = &vxfs_context_ops;
> +
> + return 0;
Superficial nit, but I would have skipped the empty line here.
Otherwise this looks good and thanks for doing the work!
Reviewed-by: Christoph Hellwig <hch@lst.de>
(and I'm fine with routing all freevxfs patches through Christian)
next prev parent reply other threads:[~2024-03-05 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 23:04 [PATCH] freevxfs: Convert freevxfs to the new mount API Eric Sandeen
2024-03-04 13:02 ` Christian Brauner
2024-03-05 13:47 ` Christoph Hellwig [this message]
2024-03-05 16:18 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeciiH1jYeT3juD7@infradead.org \
--to=hch@infradead.org \
--cc=billodo@redhat.com \
--cc=brauner@kernel.org \
--cc=kb@sysmikro.com.pl \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox