From: Jeff Layton <jlayton@kernel.org>
To: Jori Koolstra <jkoolstra@xs4all.nl>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dcache: add extra sanity checks of the dentry in dentry_free()
Date: Wed, 22 Apr 2026 09:53:14 -0400 [thread overview]
Message-ID: <a38f6cac4a7b310cec298c00030cc5e93a6e7c25.camel@kernel.org> (raw)
In-Reply-To: <1541900656.1049330.1776863765767@kpc.webmail.kpnmail.nl>
On Wed, 2026-04-22 at 15:16 +0200, Jori Koolstra wrote:
> On Wed, Apr 22, 2026 at 07:29:48AM -0400, Jeff Layton wrote:
> >
> > +#define DENTRY_WARN_ONCE(condition, dentry) \
> > + WARN_ONCE((condition), "dentry=%p d_flags=0x%x\n", (dentry), (dentry)->d_flags)
> >
>
> I guess this is one of those instances where using %p is acceptable?
> Maybe Documentation/process/deprecated.rst is worded a bit too harshly.
I'm not opposed to using something different, but I think the hashed
pointer value is fine here. Mostly I just want some way to tell whether
different warnings might have been triggered by the same dentry.
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2026-04-22 13:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 13:16 [PATCH] dcache: add extra sanity checks of the dentry in dentry_free() Jori Koolstra
2026-04-22 13:53 ` Jeff Layton [this message]
2026-04-22 14:10 ` Jori Koolstra
-- strict thread matches above, loose matches on Subject: below --
2026-04-22 11:29 Jeff Layton
2026-04-22 13:06 ` Christian Brauner
2026-04-22 14:05 ` Jeff Layton
2026-04-22 13:08 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a38f6cac4a7b310cec298c00030cc5e93a6e7c25.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=jkoolstra@xs4all.nl \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox