From: Matthew Wilcox <willy@infradead.org>
To: Kiryl Shutsemau <kirill@shutemov.name>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, Dave Chinner <david@fromorbit.com>
Subject: Re: [RFC PATCH 2/2] fs: Defer evicting inodes to a workqueue
Date: Wed, 24 Sep 2025 10:31:25 +0100 [thread overview]
Message-ID: <aNO6baMim2tFMh-C@casper.infradead.org> (raw)
In-Reply-To: <lofh4re5cnuc4byeude7idmf6m27l22tizpd4uqdmhsyochdm2@pdhq6y5plyya>
On Wed, Sep 24, 2025 at 10:28:09AM +0100, Kiryl Shutsemau wrote:
> > +static void deferred_dispose_inodes(struct list_head *inodes)
> > +{
> > + unsigned long flags;
> > +
> > + spin_lock_irqsave(&deferred_inode_lock, flags);
>
> Why _irqsave? I don't see any interactions with interrupts.
Can't we enter reclaim from paths which have interrupts disabled?
I could easily be wrong about that.
> > + list_splice_tail(inodes, &deferred_inode_list);
> > + spin_unlock_irqrestore(&deferred_inode_lock, flags);
> > +
> > + printk("deferring some inodes\n");
>
> Debug leftovers?
Oops. Thanks.
next prev parent reply other threads:[~2025-09-24 9:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 9:09 [RFC PATCH 0/2] Defer evicting inodes to a workqueue Matthew Wilcox (Oracle)
2025-09-24 9:09 ` [RFC PATCH 1/2] Add in_reclaim() Matthew Wilcox (Oracle)
2025-09-24 11:37 ` Jan Kara
2025-09-24 9:09 ` [RFC PATCH 2/2] fs: Defer evicting inodes to a workqueue Matthew Wilcox (Oracle)
2025-09-24 9:28 ` Kiryl Shutsemau
2025-09-24 9:31 ` Matthew Wilcox [this message]
2025-09-24 11:42 ` Jan Kara
2025-09-24 10:04 ` Matthew Wilcox
2025-09-24 11:41 ` Jan Kara
2025-09-24 11:55 ` Mateusz Guzik
2025-09-24 11:34 ` [RFC PATCH 0/2] " Jan Kara
2025-09-24 17:45 ` Joanne Koong
2025-09-25 11:15 ` Jan Kara
2025-10-07 0:41 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNO6baMim2tFMh-C@casper.infradead.org \
--to=willy@infradead.org \
--cc=brauner@kernel.org \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox