From: Oleg Nesterov <oleg@redhat.com>
To: Ye Liu <ye.liu@linux.dev>
Cc: Tony Luck <tony.luck@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
x86@kernel.org, Christian Brauner <brauner@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jann Horn <jannh@google.com>,
"David Hildenbrand (arm)" <david@kernel.org>,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Lorenzo Stoakes <ljs@kernel.org>, Ye Liu <liuye@kylinos.cn>,
Dave Martin <Dave.Martin@arm.com>,
James Morse <james.morse@arm.com>,
Babu Moger <babu.moger@amd.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 6/8] fs: convert process/thread iterators to for_each_*_rcu
Date: Fri, 4 Sep 2026 11:05:26 +0200 [thread overview]
Message-ID: <apqJ1t4L2KkIDRlP@redhat.com> (raw)
In-Reply-To: <20260904083001.553587-7-ye.liu@linux.dev>
On 09/04, Ye Liu wrote:
>
> @@ -1160,8 +1160,7 @@ static int __set_oom_adj(struct file *file, int oom_adj, bool legacy)
> if (mm) {
> struct task_struct *p;
>
> - rcu_read_lock();
> - for_each_process(p) {
> + for_each_process_rcu(p) {
> if (same_thread_group(task, p))
> continue;
Hmm... I am not aware of for_each_process_rcu(), but looking at this
change I guess it includes something like scope_guard(rcu) ?
Perhaps makes sense, but the naming looks sligthly confusing to me.
I mean, to for_each_process_rcu() looks like (say) list_for_each_entry_rcu()
where _rcu has another meaning...
Oleg.
next prev parent reply other threads:[~2026-09-04 9:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 8:29 [PATCH 0/8] mm: introduce for_each_process_rcu and for_each_thread_rcu Ye Liu
2026-09-04 8:29 ` [PATCH 6/8] fs: convert process/thread iterators to for_each_*_rcu Ye Liu
2026-09-04 9:05 ` Oleg Nesterov [this message]
2026-09-04 9:22 ` Lorenzo Stoakes (ARM)
2026-09-04 11:06 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apqJ1t4L2KkIDRlP@redhat.com \
--to=oleg@redhat.com \
--cc=Dave.Martin@arm.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=babu.moger@amd.com \
--cc=brauner@kernel.org \
--cc=david@kernel.org \
--cc=james.morse@arm.com \
--cc=jannh@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuye@kylinos.cn \
--cc=ljs@kernel.org \
--cc=reinette.chatre@intel.com \
--cc=rppt@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=ye.liu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox