* [PATCH] gpio: pch: add slab include
@ 2014-05-27 13:17 Linus Walleij
2014-05-27 13:45 ` Jean Delvare
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2014-05-27 13:17 UTC (permalink / raw)
To: linux-gpio; +Cc: Alexandre Courbot, Linus Walleij, Jean Delvare
After change 3ff35cbcfa4bc7d7dbdd0279e32ea677567ded02
"gpio-pch: Fix Kconfig dependencies"
which enabled COMPILE_TEST as an alternative for the PCH
driver, we get build failures like this:
drivers/gpio/gpio-pch.c: In function 'pch_gpio_probe':
drivers/gpio/gpio-pch.c:359:2: error: implicit declaration
of function 'kzalloc' [-Werror=implicit-function-declaration]
drivers/gpio/gpio-pch.c:359:7: warning: assignment makes
pointer from integer without a cast [enabled by default]
drivers/gpio/gpio-pch.c:442:2: error: implicit declaration
of function 'kfree' [-Werror=implicit-function-declaration]
Fix this by including <linux/slab.h> explicitly.
Cc: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/gpio-pch.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
index 83a156397474..d6eac9b17db9 100644
--- a/drivers/gpio/gpio-pch.c
+++ b/drivers/gpio/gpio-pch.c
@@ -20,6 +20,7 @@
#include <linux/gpio.h>
#include <linux/interrupt.h>
#include <linux/irq.h>
+#include <linux/slab.h>
#define PCH_EDGE_FALLING 0
#define PCH_EDGE_RISING BIT(0)
--
1.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: pch: add slab include
2014-05-27 13:17 [PATCH] gpio: pch: add slab include Linus Walleij
@ 2014-05-27 13:45 ` Jean Delvare
0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2014-05-27 13:45 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, Alexandre Courbot, Arnd Bergmann
Hi Linus,
Le Tuesday 27 May 2014 à 15:17 +0200, Linus Walleij a écrit :
> After change 3ff35cbcfa4bc7d7dbdd0279e32ea677567ded02
> "gpio-pch: Fix Kconfig dependencies"
> which enabled COMPILE_TEST as an alternative for the PCH
> driver, we get build failures like this:
>
> drivers/gpio/gpio-pch.c: In function 'pch_gpio_probe':
> drivers/gpio/gpio-pch.c:359:2: error: implicit declaration
> of function 'kzalloc' [-Werror=implicit-function-declaration]
> drivers/gpio/gpio-pch.c:359:7: warning: assignment makes
> pointer from integer without a cast [enabled by default]
> drivers/gpio/gpio-pch.c:442:2: error: implicit declaration
> of function 'kfree' [-Werror=implicit-function-declaration]
>
> Fix this by including <linux/slab.h> explicitly.
>
> Cc: Jean Delvare <jdelvare@suse.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/gpio/gpio-pch.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
> index 83a156397474..d6eac9b17db9 100644
> --- a/drivers/gpio/gpio-pch.c
> +++ b/drivers/gpio/gpio-pch.c
> @@ -20,6 +20,7 @@
> #include <linux/gpio.h>
> #include <linux/interrupt.h>
> #include <linux/irq.h>
> +#include <linux/slab.h>
>
> #define PCH_EDGE_FALLING 0
> #define PCH_EDGE_RISING BIT(0)
Same patch already sent by Arnd Bergmann yesterday and acked by me.
But thanks anyway :-)
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-27 13:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-27 13:17 [PATCH] gpio: pch: add slab include Linus Walleij
2014-05-27 13:45 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox