From: Alexander Stein <alexander.stein@systec-electronic.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>
Cc: Alexander Stein <alexander.stein@systec-electronic.com>,
linux-gpio@vger.kernel.org
Subject: [RFC PATCH 1/1] gpio: pca953x: Allow interrupt support when compiled as module
Date: Thu, 20 Nov 2014 15:06:19 +0100 [thread overview]
Message-ID: <1416492379-28433-1-git-send-email-alexander.stein@systec-electronic.com> (raw)
With commit 2fd36c55264926e268deb50f6de5f43fa5e490f7
("i2c: core: Map OF IRQ at probe time") it seems that there is no need
to force this driver to be compiled into the kernel.
Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
---
This is completely untested, as I lack a board capable of running a v3.18-rcX
kernel. But I noticed on an older kernel that this driver failed requesting
irq 0 during kernel boot. 0 because it's irq parent was not yet probed (also
a compiled in driver). With the mentioned commit this should work now.
It is currently only in
http://git.kernel.org/cgit/linux/kernel/git/wsa/linux.git/log/?h=i2c/for-next
drivers/gpio/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 0959ca9..29973d3 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -547,11 +547,10 @@ config GPIO_PCA953X
config GPIO_PCA953X_IRQ
bool "Interrupt controller support for PCA953x"
- depends on GPIO_PCA953X=y
select GPIOLIB_IRQCHIP
help
Say yes here to enable the pca953x to be used as an interrupt
- controller. It requires the driver to be built in the kernel.
+ controller.
config GPIO_PCF857X
tristate "PCF857x, PCA{85,96}7x, and MAX732[89] I2C GPIO expanders"
--
2.0.4
next reply other threads:[~2014-11-20 14:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 14:06 Alexander Stein [this message]
2014-11-27 7:36 ` [RFC PATCH 1/1] gpio: pca953x: Allow interrupt support when compiled as module Alexandre Courbot
2014-11-28 15:11 ` Linus Walleij
2014-12-01 7:27 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416492379-28433-1-git-send-email-alexander.stein@systec-electronic.com \
--to=alexander.stein@systec-electronic.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox