From: Alexander Stein <alexander.stein@systec-electronic.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [RFC PATCH 1/1] gpio: pca953x: Allow interrupt support when compiled as module
Date: Mon, 01 Dec 2014 08:27:57 +0100 [thread overview]
Message-ID: <30172880.4oYHgH2T9B@ws-stein> (raw)
In-Reply-To: <CACRpkdYRvBQ3WgJv7hXVbe0ubG+Gw9pgDM1Fd4HgMLPE5kQnrA@mail.gmail.com>
On Friday 28 November 2014 16:11:02, Linus Walleij wrote:
> On Thu, Nov 20, 2014 at 3:06 PM, Alexander Stein
> <alexander.stein@systec-electronic.com> wrote:
>
> > With commit 2fd36c55264926e268deb50f6de5f43fa5e490f7
> > ("i2c: core: Map OF IRQ at probe time") it seems that there is no need
> > to force this driver to be compiled into the kernel.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
>
> I don't get this at all.
>
> > config GPIO_PCA953X_IRQ
> > bool "Interrupt controller support for PCA953x"
> > - depends on GPIO_PCA953X=y
> > select GPIOLIB_IRQCHIP
> > help
> > Say yes here to enable the pca953x to be used as an interrupt
> > - controller. It requires the driver to be built in the kernel.
> > + controller.
>
> Why should this *not* be dependent on GPIO_PCA953X?? The config
> flag is only used inside the file that gets built by exactly that
> config flag!
>
> Just remove the "=y" part of the line and test if you like.
Doh, you're right. Only the =y part should be removed.
> > This is completely untested, as I lack a board capable of running a v3.18-rcX
> > kernel. But I noticed on an older kernel that this driver failed requesting
> > irq 0 during kernel boot. 0 because it's irq parent was not yet probed (also
> > a compiled in driver).
>
> If the parent is not probed, it should get an -EPROBE_DEFER
> as irq number from the parent and bail out, then that is the actual bug
> that needs fixing.
>
> > With the mentioned commit this should work now.
>
> I want it tested before I believe it...
Sure, I'll come back when I could actually test this on a more recent kernel.
Best regards,
Alexander
--
Dipl.-Inf. Alexander Stein
SYS TEC electronic GmbH
Am Windrad 2
08468 Heinsdorfergrund
Tel.: 03765 38600-1156
Fax: 03765 38600-4100
Email: alexander.stein@systec-electronic.com
Website: www.systec-electronic.com
Managing Director: Dipl.-Phys. Siegmar Schmidt
Commercial registry: Amtsgericht Chemnitz, HRB 28082
prev parent reply other threads:[~2014-12-01 7:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 14:06 [RFC PATCH 1/1] gpio: pca953x: Allow interrupt support when compiled as module Alexander Stein
2014-11-27 7:36 ` Alexandre Courbot
2014-11-28 15:11 ` Linus Walleij
2014-12-01 7:27 ` Alexander Stein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30172880.4oYHgH2T9B@ws-stein \
--to=alexander.stein@systec-electronic.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox